Change internals of EntityMap to use an std::vector
This generally makes this code cleaner and easier to maintain, while also being more modern and fully tested.
Looked at by: leper
Differential Revision: https://code.wildfiregames.com/D8
|Restricted Owners Package|
|wraitii||Jan 5 2019, 7:19 PM|
|Build 11068: Trigger Windows Autobuild|
|Build 11067: Post-Commit Build||Jenkins|
The reason for the crash is that find() didn't expect to be called with an entity below FIRST_VALID_ENTITY_ID, i.e. INVALID_ENTITY. This should return end() instead so I need to amend this code.
Inserting stuff before FIRST_VALID_ENTITY_ID should probably still crash so the ENSURE there should be fine.
The _ and __ prefixes are reserved for C++/STL, so we should avoid them.
1 Certain sets of names and function signatures are always reserved to the implementation: