HomeWildfire Games

Send a network message to update the GUI if another player pauses a multiplayer…
AuditedrP18204

Description

Send a network message to update the GUI if another player pauses a multiplayer game. Patch by echotangoecho, fixes #1950.
Pause animations then and on disconnect.
Don't unpause unintentionally when closing a message box in singleplayer.

Details

Auditors
Imarok
Committed
elexisMay 20 2016, 12:10 AM
Parents
rP18203: Network cleanup.
Branches
Unknown
Tags
Unknown

Event Timeline

Imarok raised a concern with this commit.Feb 4 2017, 12:49 PM
Imarok added a subscriber: Imarok.

When one client has finished loading, but needs to wait for other clients which are still loading he can already pause the game. This leads to multiple issues:

  • The pause message is only send to clients in NSS_INGAME so when the loading clients finished loading they don't know the game was paused.
  • Net_Clients that have finished loading(NCS_LOADING) receive the pause message from other clients that have finished loading, but they don't expect it (Fsm error)
This commit now has outstanding concerns.Feb 4 2017, 12:49 PM
elexis added a subscriber: elexis.Feb 5 2017, 6:40 AM

Refs #4261: defect: NetClient FSM error when pausing while others are loading

Imarok accepted this commit.May 12 2017, 3:25 PM
All concerns with this commit have now been addressed.May 12 2017, 3:25 PM