cleanup of the updateDiplomacy functions
Summary: Following rP19247 the diplomacy window is updated on each tick, so we can remove the old updateDiplomacy function which now only updates the player data, and rename updateDiplomacyPanel to updateDiplomacy for consistency with other windows.

Reviewed By: elexis

Differential Revision: https://code.wildfiregames.com/D172