HomeWildfire Games

Bump year number of files changed this year in the license headers.
AuditedrP19503

Description

Bump year number of files changed this year in the license headers.

Details

Event Timeline

vladislavbelov raised a concern with this commit.EditedMay 1 2017, 8:14 PM
vladislavbelov added a subscriber: vladislavbelov.

Wrong fix for source/lib/* and source/i18n/* files, they shouldn't have a dot, because they have MIT license (which hasn't a dot), not GPL-2.0 (which has), as usual.

This commit now has outstanding concerns.May 1 2017, 8:14 PM
elexis added a comment.May 2 2017, 3:49 AM

(20:29:59) elexis: it ought to become the same style globally at some point
(20:30:11) Vladislav: Yes

why.jpeg

(20:29:59) elexis: it ought to become the same style globally at some point
(20:30:11) Vladislav: Yes

The same of one type, not of all, MIT doesn't have a dot.

(20:29:59) elexis: it ought to become the same style globally at some point
(20:30:11) Vladislav: Yes

The same of one type, not of all, MIT doesn't have a dot.

Why not make it the same format for GPL and MIT? Just comes out bad if one does a grep and there are 2 characters different file all others are equal

elexis requested verification of this commit.Jul 10 2017, 4:27 PM
This commit now requires verification by auditors.Jul 10 2017, 4:27 PM
All concerns with this commit have now been addressed.Aug 29 2017, 10:00 AM