Diffusion 0 A.D. Public Repository rP20028

Pass ScriptInterface as a const ref where possible.
rP20028
Actions

Description

Pass ScriptInterface as a const ref where possible.

Reviewed By: elexis
Differential Revision: https://code.wildfiregames.com/D739

Details

Committed

• leper

Aug 24 2017, 2:32 AM

Reviewer

elexis

Differential Revision

D739: Pass ScriptInterface as a const ref where possible.

Parents

rP20027: Pass a const reference, if someone wants to modify it they should use the…

Branches

Unknown

Tags

Unknown

Build Status

Buildable 2883
Build 4958: Trigger Windows Autobuild
Build 4957: Post-Commit Build	Jenkins

Event Timeline

• leper committed rP20028: Pass ScriptInterface as a const ref where possible..Aug 24 2017, 2:32 AM

Harbormaster completed building B2883: rP20028: Pass ScriptInterface as a const ref where possible..Aug 24 2017, 3:30 AM

Changes (72)

Path

Size

ps/

trunk/

source/

graphics/

MapReader.cpp

MapReader.h

scripting/

JSInterface_GameView.cpp

JSInterface_GameView.h

gui/

scripting/

ScriptFunctions.cpp

i18n/

scripting/

lib/

lobby/

scripting/

JSInterface_Lobby.cpp

network/

ps/

GameSetup/

scripting/

JSInterface_ConfigDB.cpp

JSInterface_ConfigDB.h

JSInterface_Console.cpp

JSInterface_Console.h

JSInterface_Mod.cpp

JSInterface_Mod.h

JSInterface_VisualReplay.cpp

JSInterface_VisualReplay.h

renderer/

scripting/

JSInterface_Renderer.cpp

JSInterface_Renderer.h

scriptinterface/

NativeWrapperDecls.h

ScriptInterface.cpp

ScriptInterface.h

tests/

test_ScriptInterface.h

simulation2/

components/

tests/

docs/

scripting/

MessageTypeConversions.cpp

serialization/

system/

ComponentManagerSerialization.cpp

soundmanager/

scripting/

JSInterface_Sound.cpp

JSInterface_Sound.h

test_setup.cpp

rP20028

View Options

ps/trunk/source/graphics/MapReader.cpp

View Options

ps/trunk/source/graphics/MapReader.h

View Options

ps/trunk/source/graphics/scripting/JSInterface_GameView.cpp

View Options

ps/trunk/source/graphics/scripting/JSInterface_GameView.h

View Options

ps/trunk/source/gui/scripting/ScriptFunctions.cpp

View Options

ps/trunk/source/i18n/scripting/JSInterface_L10n.cpp

View Options

ps/trunk/source/i18n/scripting/JSInterface_L10n.h

View Options

ps/trunk/source/lib/self_test.h

View Options

ps/trunk/source/lobby/IXmppClient.h

View Options

ps/trunk/source/lobby/XmppClient.cpp

View Options

ps/trunk/source/lobby/XmppClient.h

View Options

ps/trunk/source/lobby/scripting/JSInterface_Lobby.cpp

View Options

ps/trunk/source/lobby/scripting/JSInterface_Lobby.h

View Options

ps/trunk/source/network/NetMessage.cpp

View Options

ps/trunk/source/network/NetMessage.h

View Options

ps/trunk/source/network/NetMessageSim.cpp

View Options

ps/trunk/source/network/StunClient.cpp

View Options

ps/trunk/source/network/StunClient.h

View Options

ps/trunk/source/ps/GameSetup/HWDetect.cpp

View Options

ps/trunk/source/ps/ProfileViewer.cpp

View Options

ps/trunk/source/ps/ProfileViewer.h

View Options

ps/trunk/source/ps/Replay.cpp

View Options

ps/trunk/source/ps/Replay.h

View Options

ps/trunk/source/ps/SavedGame.cpp

View Options

ps/trunk/source/ps/SavedGame.h

View Options

ps/trunk/source/ps/VisualReplay.cpp

View Options

ps/trunk/source/ps/VisualReplay.h

View Options

ps/trunk/source/ps/scripting/JSInterface_ConfigDB.cpp

View Options

ps/trunk/source/ps/scripting/JSInterface_ConfigDB.h

View Options

ps/trunk/source/ps/scripting/JSInterface_Console.cpp

View Options

ps/trunk/source/ps/scripting/JSInterface_Console.h

View Options

ps/trunk/source/ps/scripting/JSInterface_Mod.cpp

View Options

ps/trunk/source/ps/scripting/JSInterface_Mod.h

View Options

ps/trunk/source/ps/scripting/JSInterface_VisualReplay.cpp

View Options

ps/trunk/source/ps/scripting/JSInterface_VisualReplay.h

View Options

ps/trunk/source/renderer/scripting/JSInterface_Renderer.cpp

View Options

ps/trunk/source/renderer/scripting/JSInterface_Renderer.h

View Options

ps/trunk/source/scriptinterface/NativeWrapperDecls.h

View Options

ps/trunk/source/scriptinterface/ScriptInterface.cpp

View Options

ps/trunk/source/scriptinterface/ScriptInterface.h

View Options

ps/trunk/source/scriptinterface/tests/test_ScriptInterface.h

View Options

ps/trunk/source/simulation2/MessageTypes.h

View Options

ps/trunk/source/simulation2/Simulation2.cpp

View Options

ps/trunk/source/simulation2/components/ICmpAIManager.cpp

View Options

ps/trunk/source/simulation2/components/ICmpAIManager.h

View Options

ps/trunk/source/simulation2/components/tests/test_scripts.h

View Options

ps/trunk/source/simulation2/docs/SimulationDocs.h

View Options

ps/trunk/source/simulation2/scripting/MessageTypeConversions.cpp

View Options

ps/trunk/source/simulation2/scripting/ScriptComponent.cpp

View Options

ps/trunk/source/simulation2/scripting/ScriptComponent.h

View Options

ps/trunk/source/simulation2/serialization/BinarySerializer.cpp

View Options

ps/trunk/source/simulation2/serialization/BinarySerializer.h

View Options

ps/trunk/source/simulation2/serialization/DebugSerializer.cpp

View Options

ps/trunk/source/simulation2/serialization/DebugSerializer.h

View Options

ps/trunk/source/simulation2/serialization/HashSerializer.cpp

View Options

ps/trunk/source/simulation2/serialization/HashSerializer.h

View Options

ps/trunk/source/simulation2/serialization/StdDeserializer.cpp

View Options

ps/trunk/source/simulation2/serialization/StdDeserializer.h

View Options

ps/trunk/source/simulation2/serialization/StdSerializer.cpp

View Options

ps/trunk/source/simulation2/serialization/StdSerializer.h

View Options

ps/trunk/source/simulation2/system/Component.h

View Options

ps/trunk/source/simulation2/system/ComponentManager.cpp

View Options

ps/trunk/source/simulation2/system/ComponentManager.h

View Options

ps/trunk/source/simulation2/system/ComponentManagerSerialization.cpp

View Options

ps/trunk/source/simulation2/system/IComponent.cpp

View Options

ps/trunk/source/simulation2/system/IComponent.h

View Options

ps/trunk/source/simulation2/system/Interface.h

View Options

ps/trunk/source/simulation2/system/InterfaceScripted.h

View Options

ps/trunk/source/simulation2/system/Message.h

View Options

ps/trunk/source/soundmanager/scripting/JSInterface_Sound.cpp

View Options

ps/trunk/source/soundmanager/scripting/JSInterface_Sound.h

View Options

ps/trunk/source/test_setup.cpp

Pass ScriptInterface as a const ref where possible.rP20028Actions

Description

Details

Event Timeline

Changes (72)

rP20028

ps/trunk/source/graphics/MapReader.cpp

ps/trunk/source/graphics/MapReader.h

ps/trunk/source/graphics/scripting/JSInterface_GameView.cpp

ps/trunk/source/graphics/scripting/JSInterface_GameView.h

ps/trunk/source/gui/scripting/ScriptFunctions.cpp

ps/trunk/source/i18n/scripting/JSInterface_L10n.cpp

ps/trunk/source/i18n/scripting/JSInterface_L10n.h

ps/trunk/source/lib/self_test.h

ps/trunk/source/lobby/IXmppClient.h

ps/trunk/source/lobby/XmppClient.cpp

ps/trunk/source/lobby/XmppClient.h

ps/trunk/source/lobby/scripting/JSInterface_Lobby.cpp

ps/trunk/source/lobby/scripting/JSInterface_Lobby.h

ps/trunk/source/network/NetMessage.cpp

ps/trunk/source/network/NetMessage.h

ps/trunk/source/network/NetMessageSim.cpp

ps/trunk/source/network/StunClient.cpp

ps/trunk/source/network/StunClient.h

ps/trunk/source/ps/GameSetup/HWDetect.cpp

ps/trunk/source/ps/ProfileViewer.cpp

ps/trunk/source/ps/ProfileViewer.h

ps/trunk/source/ps/Replay.cpp

ps/trunk/source/ps/Replay.h

ps/trunk/source/ps/SavedGame.cpp

ps/trunk/source/ps/SavedGame.h

ps/trunk/source/ps/VisualReplay.cpp

ps/trunk/source/ps/VisualReplay.h

ps/trunk/source/ps/scripting/JSInterface_ConfigDB.cpp

ps/trunk/source/ps/scripting/JSInterface_ConfigDB.h

ps/trunk/source/ps/scripting/JSInterface_Console.cpp

ps/trunk/source/ps/scripting/JSInterface_Console.h

ps/trunk/source/ps/scripting/JSInterface_Mod.cpp

ps/trunk/source/ps/scripting/JSInterface_Mod.h

ps/trunk/source/ps/scripting/JSInterface_VisualReplay.cpp

ps/trunk/source/ps/scripting/JSInterface_VisualReplay.h

ps/trunk/source/renderer/scripting/JSInterface_Renderer.cpp

ps/trunk/source/renderer/scripting/JSInterface_Renderer.h

ps/trunk/source/scriptinterface/NativeWrapperDecls.h

ps/trunk/source/scriptinterface/ScriptInterface.cpp

ps/trunk/source/scriptinterface/ScriptInterface.h

ps/trunk/source/scriptinterface/tests/test_ScriptInterface.h

ps/trunk/source/simulation2/MessageTypes.h

ps/trunk/source/simulation2/Simulation2.cpp

ps/trunk/source/simulation2/components/ICmpAIManager.cpp

ps/trunk/source/simulation2/components/ICmpAIManager.h

ps/trunk/source/simulation2/components/tests/test_scripts.h

ps/trunk/source/simulation2/docs/SimulationDocs.h

ps/trunk/source/simulation2/scripting/MessageTypeConversions.cpp

ps/trunk/source/simulation2/scripting/ScriptComponent.cpp

ps/trunk/source/simulation2/scripting/ScriptComponent.h

ps/trunk/source/simulation2/serialization/BinarySerializer.cpp

ps/trunk/source/simulation2/serialization/BinarySerializer.h

ps/trunk/source/simulation2/serialization/DebugSerializer.cpp

ps/trunk/source/simulation2/serialization/DebugSerializer.h

ps/trunk/source/simulation2/serialization/HashSerializer.cpp

ps/trunk/source/simulation2/serialization/HashSerializer.h

ps/trunk/source/simulation2/serialization/StdDeserializer.cpp

ps/trunk/source/simulation2/serialization/StdDeserializer.h

ps/trunk/source/simulation2/serialization/StdSerializer.cpp

ps/trunk/source/simulation2/serialization/StdSerializer.h

ps/trunk/source/simulation2/system/Component.h

ps/trunk/source/simulation2/system/ComponentManager.cpp

ps/trunk/source/simulation2/system/ComponentManager.h

ps/trunk/source/simulation2/system/ComponentManagerSerialization.cpp

ps/trunk/source/simulation2/system/IComponent.cpp

ps/trunk/source/simulation2/system/IComponent.h

ps/trunk/source/simulation2/system/Interface.h

ps/trunk/source/simulation2/system/InterfaceScripted.h

ps/trunk/source/simulation2/system/Message.h

ps/trunk/source/soundmanager/scripting/JSInterface_Sound.cpp

ps/trunk/source/soundmanager/scripting/JSInterface_Sound.h

ps/trunk/source/test_setup.cpp

Pass ScriptInterface as a const ref where possible.
rP20028
Actions