Paths

Table of Contentst

Diffusion 0 A.D. Public Repository rP20079

Allow BuildRestrictions Min Max Distance to be modified by auras/technologies
AuditedrP20079
Actions

Description

Allow BuildRestrictions Min Max Distance to be modified by auras/technologies

Patch By: Grugnas

Differential Revision: https://code.wildfiregames.com/D276

Details

Auditors

s0600204

Committed

bb	Aug 30 2017, 3:02 PM

Differential Revision

D276: Allow BuildRestrictions Min Max Distance to be modified by auras/technologies

Parents

rP20078: Input GUI object cleanup.

Branches

Unknown

Tags

Unknown

Build Status

Buildable 2950
Build 5079: Post-Commit Build	Jenkins

Event Timeline

bb committed rP20079: Allow BuildRestrictions Min Max Distance to be modified by auras/technologies.Aug 30 2017, 3:02 PM

Harbormaster completed building B2950: rP20079: Allow BuildRestrictions Min Max Distance to be modified by auras/technologies.Aug 30 2017, 4:29 PM

s0600204 raised a concern with this commit.Dec 10 2017, 4:17 AM

s0600204 added a subscriber: s0600204.

s0600204 added inline comments.

/ps/trunk/binaries/data/mods/public/globalscripts/Templates.js
229	Correct me if I'm wrong, but shouldn't it be BuildRestrictions? (Missing an 'i')
232	Ditto.

This commit now has outstanding concerns.Dec 10 2017, 4:17 AM

Grepping says these are the only two occurrences of buildrestrction in code public mod code

/ps/trunk/binaries/data/mods/public/globalscripts/Templates.js
229	It should https://code.wildfiregames.com/D276?id=3187#inline-14780

bb mentioned this in rP20643: Fix missing i's in rP20079.Dec 11 2017, 4:23 PM

should be fixed by rP20643

This commit now requires verification by auditors.Dec 11 2017, 4:24 PM

Yeah, that should do it. Thanks.

All concerns with this commit have now been addressed.Dec 14 2017, 8:47 PM

Changes (2)

Path

Size

ps/

trunk/

binaries/

data/

mods/

public/

globalscripts/

Templates.js

simulation/

components/

BuildRestrictions.js

rP20079

View Options

ps/trunk/binaries/data/mods/public/globalscripts/Templates.js