Diffusion 0 A.D. Public Repository rP20125

Unify deepcopy and clone.
rP20125
Actions

Description

Unify deepcopy and clone.

Delete clone globalscripts function introduced by rP15421.
Rename the better supported deepcopy function to clone.
Delete unused Vector2D and Vector3D clone prototype functions that can just use clone if needed.

Differential Revision: https://code.wildfiregames.com/D870
Reviewed By: leper

Details

Committed

elexis

Sep 6 2017, 10:58 PM

Reviewer

• leper

Differential Revision

D870: Remove deepcopy clone

Parents

rP20124: Fix the "Thermistocles" typo in the helmet prop file name. Refs r19733.

Branches

Unknown

Tags

Unknown

Build Status

Buildable 3046
Build 5276: Trigger Windows Autobuild
Build 5275: Post-Commit Build	Jenkins

Event Timeline

elexis committed rP20125: Unify deepcopy and clone..Sep 6 2017, 10:58 PM

Harbormaster completed building B3046: rP20125: Unify deepcopy and clone..Sep 7 2017, 12:52 AM

elexis mentioned this in rP20272: Fix Vector.js rotate oversight in rP20263 (this.x may not be modified before….Oct 8 2017, 5:25 PM

Changes (11)

Path

Size

ps/

trunk/

binaries/

data/

mods/

public/

globalscripts/

utility.js

vector.js

gui/

gamesetup/

gamesetup.js

session/

session.js

maps/

random/

belgian_uplands.js

caledonian_meadows.js

heightmap/

heightmap.js

rmgen/

library.js

wild_lake.js

simulation/

components/

UnitAI.js

source/

scriptinterface/

ScriptInterface.cpp

rP20125

View Options

ps/trunk/binaries/data/mods/public/globalscripts/utility.js

View Options

ps/trunk/binaries/data/mods/public/globalscripts/vector.js

View Options

ps/trunk/binaries/data/mods/public/gui/gamesetup/gamesetup.js

View Options

ps/trunk/binaries/data/mods/public/gui/session/session.js

View Options

ps/trunk/binaries/data/mods/public/maps/random/belgian_uplands.js

View Options

ps/trunk/binaries/data/mods/public/maps/random/caledonian_meadows.js

View Options

ps/trunk/binaries/data/mods/public/maps/random/heightmap/heightmap.js

View Options

ps/trunk/binaries/data/mods/public/maps/random/rmgen/library.js

View Options

ps/trunk/binaries/data/mods/public/maps/random/wild_lake.js

View Options

ps/trunk/binaries/data/mods/public/simulation/components/UnitAI.js

View Options

ps/trunk/source/scriptinterface/ScriptInterface.cpp

Unify deepcopy and clone.rP20125Actions

Description

Details

Event Timeline

Changes (11)

rP20125

ps/trunk/binaries/data/mods/public/globalscripts/utility.js

ps/trunk/binaries/data/mods/public/globalscripts/vector.js

ps/trunk/binaries/data/mods/public/gui/gamesetup/gamesetup.js

ps/trunk/binaries/data/mods/public/gui/session/session.js

ps/trunk/binaries/data/mods/public/maps/random/belgian_uplands.js

ps/trunk/binaries/data/mods/public/maps/random/caledonian_meadows.js

ps/trunk/binaries/data/mods/public/maps/random/heightmap/heightmap.js

ps/trunk/binaries/data/mods/public/maps/random/rmgen/library.js

ps/trunk/binaries/data/mods/public/maps/random/wild_lake.js

ps/trunk/binaries/data/mods/public/simulation/components/UnitAI.js

ps/trunk/source/scriptinterface/ScriptInterface.cpp

Unify deepcopy and clone.
rP20125
Actions