HomeWildfire Games

Rearrange tower templates

Description

Rearrange tower templates

Rename tower techs to tower_{tech}
Remove duplication in tower templates
Create tower parent, with sentry, stone and outpost as childs
Move all outpost as child of tower
Add a sentry tower default building

refs #4849

Patch By: Nescio
Differential Revision: https://code.wildfiregames.com/D914

Details

Committed
bbNov 15 2017, 10:16 PM
Differential Revision
D914: tower templates
Parents
rP20458: New bows and arrows for every civ ! Blendfiles are in the repo.
Branches
Unknown
Tags
Unknown
Build Status
Buildable 3720
Build 6461: Post-Commit BuildJenkins

Event Timeline

elexis added a subscriber: elexis.Nov 15 2017, 10:35 PM
elexis added inline comments.
/ps/trunk/binaries/data/mods/public/simulation/data/technologies/tower_crenellations.json
2

Bye bye revision history

Move all outpost as child of tower

Not sure, an outpost is intrinsically different from a tower, since the former is built outside of the territory for the purpose of gaininig vision (in both realworld and ingame) and the latter built in owned territory as a defensive structure.

/ps/trunk/binaries/data/mods/public/simulation/data/technologies/tower_vision.json
14

Why is this called tower_vision if it only applies to outposts but not towers?

/ps/trunk/binaries/data/mods/public/simulation/templates/template_structure_defense_tower_outpost.xml
103

Isn't it rather a coincidence that these values are equal to tower values?

/ps/trunk/binaries/data/mods/public/simulation/templates/template_structure_defense_tower_sentry.xml
64

Moving these values to the child templates seems good

bb added a comment.Nov 15 2017, 11:01 PM

Move all outpost as child of tower

Not sure, an outpost is intrinsically different from a tower, since the former is built outside of the territory for the purpose of gaininig vision (in both realworld and ingame) and the latter built in owned territory as a defensive structure.

Outpost also shoot arrows when garrisoned, thus they are defense works too, and even towers. Do notice there is a parent template for the 3 types and a child for each of them, and that the parent contains the global stuff. Also in real world buildings for vision are generally towers (there is a reason for the phrase "watch tower"), so imo outpost are as much towers as the stone and sentry tower are.

/ps/trunk/binaries/data/mods/public/simulation/data/technologies/tower_vision.json
14

since outpost is under a tower parent, so outpost has become a tower, so techs are named after that

/ps/trunk/binaries/data/mods/public/simulation/templates/template_structure_defense_tower_outpost.xml
103

No since outpost have the same type of garrison and attack as sentries and stone towers, and mostly those values are moved to the parent

Alright, should work then. Thanks for the patch and review!

bb added a comment.Nov 17 2017, 1:16 PM

StoneTower class should have been added to the identity docs