HomeWildfire Games

Add support for diplomacy changes for wonder victory, make notifications more…

Description

Add support for diplomacy changes for wonder victory, make notifications more correct, add behaviour string to the gamedescription panel and on the fly cleanup

Reviewed By: elexis
Differential Revision: https://code.wildfiregames.com/D881

Event Timeline

elexis added a subscriber: elexis.Apr 4 2018, 12:34 AM

@bb I don't know which commit broke it, but we played an LMS game, yet two players were marked as having won wonder victory.

It's a long game, so probably shouldn't use this replay to reproduce:
r21646

temple added a subscriber: temple.EditedApr 4 2018, 1:28 AM

@bb I don't know which commit broke it, but we played an LMS game, yet two players were marked as having won wonder victory.

Which two?

--
Turn 6209 (500)...
wonder victory player defeated ({playerId:4})
--
Turn 6361 (500)...
wonder victory ownership changed ({entity:15659, from:-1, to:1})
wonder victory start timer 15659, player 1
allies = [], others = [-1, 2, 3, 4, 5]
--
Turn 7880 (500)...
wonder victory ownership changed ({entity:17182, from:-1, to:2})
wonder victory start timer 17182, player 2
allies = [], others = [-1, 1, 3, 4, 5]
--
Turn 9199 (500)...
wonder victory ownership changed ({entity:17182, from:2, to:-1})
wonder victory delete timer 17182
--
Turn 9560 (500)...
wonder victory player defeated ({playerId:2})
--
Turn 10561 (500)...
wonder victory set winner 1
wonder victory player won ({playerId:1})
wonder victory delete timer 15659
wonder victory player defeated ({playerId:3})
wonder victory player defeated ({playerId:5})

Edit:

mark players as won, winningPlayers = [1], defeatedPlayers = [3, 5]
elexis added a comment.Apr 4 2018, 1:47 AM

I didn't take a screenshot, but I think the GUI notification stated that Cesar and me had won. We were allies before the wonder was built until the end. The summary screen info also claims only that I was a winner however.
I can do a visual replay tomorrow.
(In case you just ran a simulation replay and still have the profile.txt, it would be interesting to see).

temple added a comment.Apr 4 2018, 2:14 AM

(In case you just ran a simulation replay and still have the profile.txt, it would be interesting to see).

Did it three times, kept remembering other things I wanted to print, 15m each.

Guessing some locked gates at the spike.

elexis added a comment.Apr 5 2018, 1:59 PM

I didn't replay the thing, but I assume I mistook the defeated line for the victory line, as it said (wonder victory) for the defeated players too. At least wonder should start with a capital letter, right?