Diffusion 0 A.D. Public Repository rP20958

Implement an auto-scroll setting for GUI lists.
rP20958
Actions

Description

Implement an auto-scroll setting for GUI lists.

Patch By: fpre / ffffffff
Fixes #4987, refs #4254

This allows the replay menu and lobby to focus the selected element if, but only if it is expected by the user.
Replaces rP18935 which scrolled the selected player into view every single time a new playerlist was received by the lobby server.

Details

Committed

elexis

Jan 22 2018, 5:45 AM

Parents

rP20957: Randomize the river angle on Danubius, refs #4855.

Branches

Unknown

Tags

Unknown

Build Status

Buildable 4606
Build 8026: Trigger Windows Autobuild
Build 8025: Post-Commit Build

Event Timeline

elexis committed rP20958: Implement an auto-scroll setting for GUI lists..Jan 22 2018, 5:45 AM

Harbormaster failed to build B4606: rP20958: Implement an auto-scroll setting for GUI lists.!Jan 22 2018, 5:45 AM

elexis mentioned this in D1232: Scrollbug when player/gamelist receives update in lobby.Jan 22 2018, 5:59 AM

elexis mentioned this in rP18935: Scroll to the selected element after the selection changes. Fixes #4254, refs….Jan 22 2018, 6:16 AM

elexis added inline comments.Jan 28 2018, 6:27 PM

/ps/trunk/source/gui/CList.cpp
60	bool, as reported by Angen in D1266

elexis mentioned this in D1266: CList type fix.Jan 28 2018, 6:28 PM

elexis mentioned this in rP21047: Fix wrong type in rP20958 / D1232..Jan 28 2018, 6:38 PM

ffffffff added a subscriber: ffffffff.Jan 28 2018, 7:38 PM

ffffffff added inline comments.

/ps/trunk/source/gui/CList.cpp
60	au

Changes (7)

Path

Size

ps/

trunk/

binaries/

data/

mods/

mod/

gui/

gui.rnc

gui.rng

modmod/

modmod.xml

public/

gui/

loadgame/

load.xml

lobby/

lobby.js

replaymenu/

replay_menu.xml

source/

gui/

CList.cpp

rP20958

View Options

ps/trunk/binaries/data/mods/mod/gui/gui.rnc

View Options

ps/trunk/binaries/data/mods/mod/gui/gui.rng

View Options

ps/trunk/binaries/data/mods/mod/gui/modmod/modmod.xml

View Options

ps/trunk/binaries/data/mods/public/gui/loadgame/load.xml

View Options

ps/trunk/binaries/data/mods/public/gui/lobby/lobby.js

View Options

ps/trunk/binaries/data/mods/public/gui/replaymenu/replay_menu.xml

View Options

ps/trunk/source/gui/CList.cpp

Implement an auto-scroll setting for GUI lists.rP20958Actions

Description

Details

Event Timeline

Changes (7)

rP20958

ps/trunk/binaries/data/mods/mod/gui/gui.rnc

ps/trunk/binaries/data/mods/mod/gui/gui.rng

ps/trunk/binaries/data/mods/mod/gui/modmod/modmod.xml

ps/trunk/binaries/data/mods/public/gui/loadgame/load.xml

ps/trunk/binaries/data/mods/public/gui/lobby/lobby.js

ps/trunk/binaries/data/mods/public/gui/replaymenu/replay_menu.xml

ps/trunk/source/gui/CList.cpp

Implement an auto-scroll setting for GUI lists.
rP20958
Actions