HomeWildfire Games
Diffusion 0 A.D. Public Repository rP21778

Move ModIo JS interface functions to a separate namespace, refs rP21759.
rP21778
Actions

Description

Move ModIo JS interface functions to a separate namespace, refs rP21759.

Differential Revision: https://code.wildfiregames.com/D1466
Reviewed By: Itms

Details

Committed
elexisApr 24 2018, 3:12 PM
Reviewer
Itms
Differential Revision
D1466: Separate ModIo JSInterface from Mod
Parents
rP21777: Fix gaia units ignoring players without CCs.
Branches
Unknown
Tags
Unknown
Build Status
Buildable 5964
Build 9951: Trigger Windows Autobuild
Build 9950: Post-Commit BuildJenkins

Event Timeline

elexis committed rP21778: Move ModIo JS interface functions to a separate namespace, refs rP21759..Apr 24 2018, 3:12 PM
Harbormaster completed building B5964: rP21778: Move ModIo JS interface functions to a separate namespace, refs rP21759..Apr 24 2018, 5:01 PM
elexis added inline comments.Apr 25 2018, 4:13 PM
/ps/trunk/source/ps/scripting/JSInterface_ModIo.cpp
23

unused include. it once complained after I removed it, but now it doesn't anymore, should have checked once more after fixing the other references again

/ps/trunk/source/ps/scripting/JSInterface_ModIo.h
21

unused include, copypasta

24

and this forward declaration is as useless as the one it was copied from in rP20591

elexis mentioned this in D1470: Remove some unused includes and redundant forward declarations.Apr 25 2018, 5:01 PM
elexis mentioned this in rP21788: Clean some forward declarations..Apr 27 2018, 6:07 PM

Changes (5)

PathSize
ps/
trunk/
source/
gui/
scripting/
ps/
scripting/

rP21778

View Options

ps/trunk/source/gui/scripting/ScriptFunctions.cpp

Loading...
View Options

ps/trunk/source/ps/scripting/JSInterface_Mod.cpp

Loading...
View Options

ps/trunk/source/ps/scripting/JSInterface_Mod.h

Loading...
View Options

ps/trunk/source/ps/scripting/JSInterface_ModIo.cpp

Loading...
View Options

ps/trunk/source/ps/scripting/JSInterface_ModIo.h

Loading...
Wildfire Games ยท Phabricator