temple Apr 26 2018, 1:47 AM
- rP21783: Revert sinkrate change from rP21732 which was too drastic (15x).
- Build Status
Buildable 5972 Build 9962: Post-Commit Build Jenkins
It doesn't make them worse because in a22 every unit (except packable units) in standground would chase in attack-move, and now packable units will also chase (the point of your original commit was to remove the inconsistencies with packable units) rather than being bugged.
But as it seems that now, the new rule is to commit patches without acceptation,
I agree with temple proposition in rP21630 (switching the order of the standground check and the pack)
That said, having the canPack at the place you mention seems to be useful to avoid units to be stuck.
which sounded to me like you agreed with the changes I made.
I didn't say "Reviewed by mimo" because you didn't official accept them, but still.
Never extract some sentences out of context please! In all my answers, i also added that all that had to be completed by the change in attack-move.
It makes thing worse because if i set my pack unit to standground, it means i don't want it to chase units it has not chance to catch up, and will be drifted far from protective soldiers.