Fix UnitAI behaviour inconsistent with its stance for packed units and set default stance to standground for packed units.
Reviewed By: temple
Trac Tickets: #5091
Differential Revision: https://code.wildfiregames.com/D1413
Description
Description
Details
Details
- Auditors
bb elexis - Committed
mimo Mar 27 2018, 7:56 PM - Reviewer
- temple
- Differential Revision
- D1413: Fix UnitAI behaviour inconsistent with its stance for packed units
- Parents
- rP21629: Final barrack split assets for Rome, Greece, and Gaul.
- Branches
- Unknown
- Tags
- Build Status
Buildable 5707 Build 9585: Post-Commit Build
Event Timeline
| /ps/trunk/binaries/data/mods/public/simulation/components/UnitAI.js | ||
|---|---|---|
| 488–492 | now we have the bug the other way around: siege tries to chase, and thus pack again while it is forbidden by their stance. As a result a standground siege will repeatedly pack and unpack when a unit comes in and out of range. | |
| /ps/trunk/binaries/data/mods/public/simulation/components/UnitAI.js | ||
|---|---|---|
| 467–482 | whatever, have to admit that I didn't examen the code thoroughly, probably you are right | |
| /ps/trunk/binaries/data/mods/public/simulation/components/UnitAI.js | ||
|---|---|---|
| 467–482 | (Seems like the focus lies more on exams than examining patches) | |
| /ps/trunk/binaries/data/mods/public/simulation/components/UnitAI.js | ||
|---|---|---|
| 456 | Removing this check introduced a behavior that is not expected and can't be intended. If a siege engine has an enemy in vision range, it will start unpacking. I don't know how the code and the feature should be, but it can't be intended that one has to wait unpack and pack to get into a state where one can move the packed unit. Reported at #5328. | |