Diffusion 0 A.D. Public Repository rP22253

Move the Vertex Pathfinder to its own helper class
rP22253
Actions

Description

Move the Vertex Pathfinder to its own helper class

The vertex pathfinder was implemented directly in CCmpPathfinder, instead of being a separate helper like the hierarchical pathfinder or the long pathfinder.

This moves it to its own helper VertexPathfinder, which gets us ready for D14 and pathfinder threading. Some struct definitions need to be moved around.

Differential Revision: https://code.wildfiregames.com/D1855

Details

Committed

wraitii

May 8 2019, 1:53 PM

Differential Revision

D1855: Move the Vertex Pathfinder to its own class

Parents

rP22252: Add dirt decals to rome factions temple:

Branches

Unknown

Tags

Unknown

Reverted By

D2024: Avoid VertexPathfinder pointer in rP22253

Build Status

Buildable 7384
Build 12029: Trigger Windows Autobuild
Build 12028: Post-Commit Build	Jenkins

Event Timeline

wraitii committed rP22253: Move the Vertex Pathfinder to its own helper class.May 8 2019, 1:53 PM

wraitii mentioned this in D1867: Decouple long and hierarchical pathfinders somewhat..May 8 2019, 1:56 PM

Harbormaster completed building B7384: rP22253: Move the Vertex Pathfinder to its own helper class.May 8 2019, 2:30 PM

wraitii mentioned this in rP22278: Decouple long and hierarchical pathfinders to an extent..May 13 2019, 6:58 PM

Move the Vertex Pathfinder to its own helper class

Seems good.

/ps/trunk/source/simulation2/components/CCmpPathfinder.cpp
57	Pointers can null-deref and needs protection or extra-caution for that. Given that the previous code didn't necessitate pointers, I assume (perhaps wrongfully?) that a pointer is not necessary here

wraitii added inline comments.Jun 28 2019, 4:52 PM

/ps/trunk/source/simulation2/components/CCmpPathfinder.cpp
57	It is necessary because references must be initialised in the constructor (this is Init). Making this not a const-ref would blow up the size of the pathfinder component, which I don't think is a great idea - can be debated.