HomeWildfire Games

Small commands.js cleanup


Small commands.js cleanup

Differential Revision: https://code.wildfiregames.com/D1504

Event Timeline

elexis raised a concern with this commit.EditedMay 31 2019, 10:54 PM
  • It's WFG practice to grant attribution in the commit message to every author
  • It's in the interest of the author to preserve the nickname in the revision history and propoagation to mirrors.
  • There was a kind request to have this reverted yesterday.
  • The committer had announced absence prior to this request, but left a message agreeing to have this reverted (edit: and committed with proper attribution again as proposed in the request).
This commit now has outstanding concerns.May 31 2019, 10:54 PM
elexis added inline comments.May 31 2019, 11:03 PM

(also we don't have that && there, there is a JShint and Jenkins rule for that)

elexis removed an auditor: elexis.Jun 2 2019, 1:29 PM
This commit no longer requires audit.Jun 2 2019, 1:29 PM