HomeWildfire Games

Common template name change: hellenic_royal_stoa → stoa
AuditedrP22770

Description

Common template name change: hellenic_royal_stoa → stoa

The old name was unnecessary long, but also potentially misleading: stoas are Greek, but not necessary royal, and there are no other stoas in game. Just “stoa” is clearer, more correct, and more consistent with other template_structure_*.xml names.

Patch By: Nescio

Reviewed By: wraitii

Differential Revision: https://code.wildfiregames.com/D2036

Details

Auditors
Stan
Committed
wraitiiAug 24 2019, 11:00 AM
Reviewer
wraitii
Differential Revision
D2036: hellenic_royal_stoa → stoa
Parents
rP22769: Make damage bonuses, attack preferred classes and garrisonHolder ejectable…
Branches
Unknown
Tags
Unknown
Build Status
Buildable 9042
Build 14813: Post-Commit BuildJenkins

Event Timeline

Stan raised a concern with this commit.Sep 5 2019, 12:16 AM
Stan added a subscriber: Stan.

According to checkrefs.pl
Missing file 'simulation/templates/template_structure_civic_hellenic_royal_stoa.xml' referenced by: 'public/maps/scenarios/Miletus.xml'

This commit now has outstanding concerns.Sep 5 2019, 12:16 AM
Stan accepted this commit.Sep 8 2019, 2:40 PM

Fixed in rP22871

All concerns with this commit have now been addressed.Sep 8 2019, 2:40 PM