HomeWildfire Games
Diffusion 0 A.D. Public Repository rP22779

Remove unused GUIUtil functions, unused GUI includes and some tails in GUIUtil.
rP22779
Actions

Description

Remove unused GUIUtil functions, unused GUI includes and some tails in GUIUtil.

HasSetting from rP22693 is actually redundant with IGUIObject::SettingExists.
GetSettingPointer from rP1518 is superseded by GetSetting reference following rP22693 and rP22765.
Deregister copying SetSetting variants for CStr and CStrW following copy removal in rP22765.
The default template <typename T=int> from rP31 can be removed following FallBackSprite/FallBackColor removal in rP22689 and RecurseObject unification in rP22744.
Delete all unused GUI includes, refs D1478.
Remove GUIUtil friend class following something.

Differential Revision: https://code.wildfiregames.com/D2225
Tested on: gcc 9.1.0, Jenkins

Details

Committed
elexisAug 25 2019, 10:57 AM
Differential Revision
D2225: Remove unused antique GUIUtil functions and unused GUI includes
Parents
rP22778: [Windows] Automated build.
Branches
Unknown
Tags
Unknown
Build Status
Buildable 9067
Build 14858: Trigger Windows Autobuild
Build 14857: Post-Commit BuildJenkins

Event Timeline

elexis committed rP22779: Remove unused GUIUtil functions, unused GUI includes and some tails in GUIUtil..Aug 25 2019, 10:57 AM
elexis added an edge: D2225: Remove unused antique GUIUtil functions and unused GUI includes.
Harbormaster completed building B9067: rP22779: Remove unused GUIUtil functions, unused GUI includes and some tails in GUIUtil..Aug 25 2019, 11:11 AM
elexis added a comment.Aug 26 2019, 2:02 PM

The default template <typename T=int> from rP31 can be removed following FallBackSprite/FallBackColor removal in rP22689 and RecurseObject unification in rP22744.

* int is only to please functions that doesn't even use T
* and are only within this class because it's convenient

GUI<int>::ParseColor removed in rP22662 also used T=int without using it.

Changes (12)

PathSize
ps/
trunk/
source/
graphics/
gui/
lobby/
scripting/
network/
ps/
GameSetup/
renderer/
tools/
atlas/
GameInterface/
Handlers/

rP22779

View Options

ps/trunk/source/graphics/CinemaManager.cpp

Loading...
View Options

ps/trunk/source/gui/GUIRenderer.cpp

Loading...
View Options

ps/trunk/source/gui/GUItypes.h

Loading...
View Options

ps/trunk/source/gui/GUIutil.cpp

Loading...
View Options

ps/trunk/source/gui/GUIutil.h

Loading...
View Options

ps/trunk/source/lobby/scripting/JSInterface_Lobby.cpp

Loading...
View Options

ps/trunk/source/network/NetClientTurnManager.cpp

Loading...
View Options

ps/trunk/source/ps/GameSetup/GameSetup.cpp

Loading...
View Options

ps/trunk/source/ps/SavedGame.cpp

Loading...
View Options

ps/trunk/source/ps/VisualReplay.cpp

Loading...
View Options

ps/trunk/source/renderer/PostprocManager.cpp

Loading...
View Options

ps/trunk/source/tools/atlas/GameInterface/Handlers/GraphicsSetupHandlers.cpp

Loading...
Wildfire Games ยท Phabricator