Diffusion 0 A.D. Public Repository rP22911

Report and tolerate XML GUI object setting errors when parsing XML attribute…
rP22911
Actions

Description

Report and tolerate XML GUI object setting errors when parsing XML attribute strings as values for settings that don't exist on the GUI object.

Following rP290, rP1494, rP14953, ... the XML errors were silently ignored.
Following rP22796 it led to a crash (m_Setting access for an item that does not exist).

Differential Revision: https://code.wildfiregames.com/D2297
Tested on: clang 8.0.1, Jenkins

Details

Committed

elexis

Sep 16 2019, 6:13 PM

Differential Revision

D2297: Report and tolerate errors when parsing strings as values for settings that don't exist

Parents

rP22910: [i18n] Updated POT and PO files.

Branches

Unknown

Tags

Unknown

Build Status

Buildable 9414
Build 15664: Trigger Windows Autobuild
Build 15663: Post-Commit Build	Jenkins

Event Timeline

elexis committed rP22911: Report and tolerate XML GUI object setting errors when parsing XML attribute….Sep 16 2019, 6:13 PM

elexis added an edge: D2297: Report and tolerate errors when parsing strings as values for settings that don't exist.

elexis mentioned this in rP22796: Move static GUI<>::SetSetting operating on IGUIObject to a member IGUIObject….Sep 16 2019, 6:20 PM

Harbormaster completed building B9414: rP22911: Report and tolerate XML GUI object setting errors when parsing XML attribute….Sep 16 2019, 6:21 PM

Changes (2)

Path

Size

ps/

trunk/

source/

gui/

CGUI.cpp

IGUIObject.cpp

rP22911

View Options

ps/trunk/source/gui/CGUI.cpp