HomeWildfire Games

Rewrite Savegame page to use class syntax, enabled by rP22923 / D2290, refs…

Description

Rewrite Savegame page to use class syntax, enabled by rP22923 / D2290, refs #5387.

Uses simple event subscription to make the classes independent of each other.
Removes all globals except two variables and one function (that may be avoided in the future too).
Allows the reader to focus on the relevant aspect of the implementation (encapsulation, information hiding) and makes implementation more modifiable and extensible.

Differential Revision: https://code.wildfiregames.com/D2310

Event Timeline

Silier added a subscriber: Silier.Dec 2 2019, 8:13 AM
Silier added inline comments.
/ps/trunk/binaries/data/mods/public/gui/loadgame/SavegameDetails.js
35

we might here get similar warning like displayed in ticket #564

WARNING: JavaScript warning: gui/common/functions_utility_loadsave.js line 8
reference to undefined property metadata.mods

file available in https://code.wildfiregames.com/rP22923#change-JeUpOwROZHF3

Stan added a subscriber: Stan.Dec 2 2019, 8:26 AM
Stan added inline comments.
/ps/trunk/binaries/data/mods/public/gui/loadgame/SavegameDetails.js
35

I think you mean #5645

Silier added inline comments.Dec 2 2019, 8:27 AM
/ps/trunk/binaries/data/mods/public/gui/loadgame/SavegameDetails.js
35