Diffusion 0 A.D. Public Repository rP23112

ceasefire overlay counter visibility following…
rP23112
Actions

Description

Fix FPS/realtime/matchtime/ceasefire overlay counter visibility following rP23096/D2391 when starting with all counters disabled or starting a match with ceasefire disabled but ceasefire counter enabled, reported by Polakrity.

Details

Committed

elexis

Oct 29 2019, 5:28 PM

Parents

rP23111: [Windows] Automated build.

Branches

Unknown

Tags

Unknown

Build Status

Buildable 9898
Build 16685: Post-Commit Build	Jenkins

Event Timeline

elexis committed rP23112: Fix FPS/realtime/matchtime/ceasefire overlay counter visibility following….Oct 29 2019, 5:28 PM

Stan added a subscriber: Stan.Oct 29 2019, 5:33 PM

Stan added inline comments.

/ps/trunk/binaries/data/mods/public/gui/common/OverlayCounterManager.js
16	Sure it's still used ? I see only one reference at line 96 and it's never assigned...

Harbormaster completed building B9898: rP23112: Fix FPS/realtime/matchtime/ceasefire overlay counter visibility following….Oct 29 2019, 5:35 PM

elexis mentioned this in rP23113: Fix performance improvement (50 microsec/call) valuesetting missing in….Oct 30 2019, 11:36 AM

elexis added inline comments.Oct 30 2019, 11:39 AM

/ps/trunk/binaries/data/mods/public/gui/common/OverlayCounterManager.js
16	"still" is a bit inaccurate since the assignment is missing since introduction in rP23096. Sso after this commit rP23112 it was updated every call. Missing assignment added rP23113, thanks for the report, silly me.