HomeWildfire Games

Heal HP → Health, Rate → Interval

Description

Heal HP → Health, Rate → Interval

Patch By: Nescio
Differential Revision: D2842

Event Timeline

bb added inline comments.Jul 21 2020, 6:35 PM
/ps/trunk/binaries/data/mods/public/gui/common/tooltips.js
837

This ought to be wrong in some languages

Silier added a subscriber: Silier.Jul 21 2020, 7:31 PM
Silier added inline comments.
/ps/trunk/binaries/data/mods/public/gui/common/tooltips.js
837

yep,
we need plural.
I cant see it translatable to sk for example.
Heal 1/2/5: Health
Lieč: 1 život
Lieč: 2 životy
Lieč: 5 životov
Although Health would be translated more like Zdravie but it would sound too strange in the context, anyway even that has plurals which will sound even worse, what means someone will probably change it in translation to život what is above or back to HP.

Nescio added a subscriber: Nescio.Jul 21 2020, 7:43 PM
Nescio added inline comments.
/ps/trunk/binaries/data/mods/public/gui/common/tooltips.js
837

(Translators have the flexibility to do whatever they think is best for their language.)

Silier added inline comments.Jul 21 2020, 7:53 PM
/ps/trunk/binaries/data/mods/public/gui/common/tooltips.js
837

Yes, but with singular translation they cant even to translate it correctly for plural parts.

Nescio added inline comments.Jul 21 2020, 8:04 PM
/ps/trunk/binaries/data/mods/public/gui/common/tooltips.js
837

rP23864
Out of curiosity, does translatePlural support the dual?

Silier added inline comments.Jul 21 2020, 8:06 PM
/ps/trunk/binaries/data/mods/public/gui/common/tooltips.js
837

translatePlural works based on this: rP23690

Nescio added inline comments.Jul 21 2020, 8:08 PM
/ps/trunk/binaries/data/mods/public/gui/common/tooltips.js
837

They're hardcoded?

For better undertanding:
It takes number and computes which form provided by translators it should use.

Silier added inline comments.Jul 21 2020, 8:10 PM
/ps/trunk/binaries/data/mods/public/gui/common/tooltips.js
837

based on what transifex puts in po files.
Yes, we would need another library for it to not be hardcoded but they do not change so often,