HomeWildfire Games
Diffusion 0 A.D. Public Repository rP23993

Move "GetDamageBonus"-function from its own helper file to "Attacking.js"…
rP23993
Actions

Description

Move "GetDamageBonus"-function from its own helper file to "Attacking.js"-helper.

Also cache calls to cmpIdentity to improve performance for multiple bonuses.

Differential Revision: D2970
Reviewed by: @bb.

Details

Committed
FreagarachAug 24 2020, 5:17 PM
Differential Revision
D2970: Move 'GetDamageBonus"-function from its own helper file to 'Attacking.js'-helper.
Parents
rP23992: Fix more JsDocs numbers/bools/strings
Branches
Unknown
Tags
Unknown
Build Status
Buildable 12977
Build 25569: Post-Commit BuildJenkins
Build 25568: Post-Commit Build (macOS)Jenkins

Changes (5)

PathSize
ps/
trunk/
binaries/
data/
mods/
public/
simulation/
components/
tests/
helpers/

rP23993

View Options

ps/trunk/binaries/data/mods/public/simulation/components/tests/test_Attack.js

Loading...
View Options

ps/trunk/binaries/data/mods/public/simulation/components/tests/test_Damage.js

Loading...
View Options

ps/trunk/binaries/data/mods/public/simulation/components/tests/test_DeathDamage.js

Loading...
View Options

ps/trunk/binaries/data/mods/public/simulation/helpers/Attacking.js

Loading...
View Options

ps/trunk/binaries/data/mods/public/simulation/helpers/DamageBonus.js

Loading...
Wildfire Games · Phabricator