Fix rP24306 - actually speed up MP/lobby chat.
rP24306 / D1781 would fix an important source of lag... If it actually used the code.
Also clean up some comments.
Reported by: Vladislav
Differential Revision: https://code.wildfiregames.com/D3176
Description
Description
Details
Details
- Auditors
vladislavbelov - Committed
wraitii Dec 2 2020, 10:28 AM - Differential Revision
- D3176: Fix rP24306 - actually use the code.
- Parents
- rP24311: [Windows] Automated build.
- Branches
- Unknown
- Tags
- Build Status
Buildable 14089 Build 29408: Trigger Windows Autobuild Build 29407: Post-Commit Build Jenkins Build 29406: Post-Commit Build (macOS) Jenkins
Event Timeline
| /ps/trunk/source/gui/ObjectTypes/CList.cpp | ||
|---|---|---|
| 129 | That makes things more dangerous. Since you haven't added any explicit dependency, that SetupText(true) can't be called before SetupText(false). Usually appending should work for an empty container like assigning, not UB. | |
| /ps/trunk/source/gui/ObjectTypes/CList.cpp | ||
|---|---|---|
| 129 | Indeed... In fact back() was actually not equivalent to the code before, because that used m_List.m_Items instead of m_ItemsYPositions's length, which is why I needed to move this line and didn't see the UB. It so happens that SetupText() is called immediately because we have a scrollbar, but I'll fix it regardless. | |
| /ps/trunk/source/gui/ObjectTypes/CList.cpp | ||
|---|---|---|
| 131 | I suppose m_List.m_Items can be empty, so there is a dangerous code still. | |
| /ps/trunk/source/gui/ObjectTypes/CList.cpp | ||
|---|---|---|
| 131 | Mh, yeah, this list is always appended to before calling SetupText with append, but it is a bit of a gotcha. | |