Diffusion 0 A.D. Public Repository rP24466

Fix serialization errors when hosting MP game.
rP24466
Actions

Description

Fix serialization errors when hosting MP game.

Follows D2746 / rP24462 and rP24167.
Player colors are copied from the settings, which are deep-frozen, thus not extensible. Cloning them restores that, allowing serialization.

Reported By: Angen

Differential Revision: https://code.wildfiregames.com/D3263

Details

Committed

wraitii

Dec 28 2020, 6:44 PM

Differential Revision

D3263: Fix serialization errors when hosting MP game.

Parents

rP24465: [i18n] Updated POT and PO files.

Branches

Unknown

Tags

Unknown

Reverted By

rP24563: Revert rP24167 / Keep track of serialized objects using a GCHashTable
D3336: Revert rP24167 / Keep track of serialized objects using a map.

Build Status

Buildable 14620
Build 31200: Post-Commit Build	Jenkins
Build 31199: Post-Commit Build (macOS)	Jenkins

Event Timeline

wraitii committed rP24466: Fix serialization errors when hosting MP game..Dec 28 2020, 6:44 PM

wraitii added an edge: D3263: Fix serialization errors when hosting MP game..

vladislavbelov added a subscriber: vladislavbelov.Dec 28 2020, 7:44 PM

vladislavbelov added inline comments.

/ps/trunk/binaries/data/mods/public/gui/gamesetup/Pages/GameSetupPage/GameSettings/PerPlayer/Dropdowns/PlayerColor.js
51	I think we should have a comment for modders, why they need to write like this. At the moment it seems like a workaround for them.

Harbormaster completed building B14620: rP24466: Fix serialization errors when hosting MP game..Dec 28 2020, 7:44 PM

wraitii mentioned this in D3336: Revert rP24167 / Keep track of serialized objects using a map..Jan 12 2021, 7:17 PM

wraitii added a reverting change: D3336: Revert rP24167 / Keep track of serialized objects using a map..Jan 12 2021, 7:18 PM

wraitii added a reverting change: rP24563: Revert rP24167 / Keep track of serialized objects using a GCHashTable.Jan 12 2021, 7:45 PM

Changes (1)

Path

Size

ps/

trunk/

binaries/

data/

mods/

public/

gui/

gamesetup/

Pages/

GameSetupPage/

GameSettings/

PerPlayer/

Dropdowns/

PlayerColor.js

rP24466

View Options

ps/trunk/binaries/data/mods/public/gui/gamesetup/Pages/GameSetupPage/GameSettings/PerPlayer/Dropdowns/PlayerColor.js