Diffusion 0 A.D. Public Repository rP24764

Revert rP24280, causing false OOS in visual replays.
rP24764
Actions

Description

Revert rP24280, causing false OOS in visual replays.

rP24280 fixed #5546, but it seems to cause some rare OOS in visual replays, as reported in #5909. The culprit is likely that hashes aren't computed at quite the same moment and onDestroy changes things.

Reverting for now before A24.

Reported by: Angen

Refs #5546.
Fixes #5909

Details

Committed

wraitii

Jan 22 2021, 6:13 PM

Parents

rP24763: Update bundle dist tools

Branches

Unknown

Tags

Unknown

Reverts

D3067: Fix visual-replays not processing turn 0 commands.
rP24280: Fix visual-replays not processing turn 0 commands.

Build Status

Buildable 15349
Build 33469: Trigger Windows Autobuild
Build 33468: Post-Commit Build	Jenkins
Build 33467: Post-Commit Build (macOS)	Jenkins

Event Timeline

wraitii committed rP24764: Revert rP24280, causing false OOS in visual replays..Jan 22 2021, 6:13 PM

wraitii added reverted changes: rP24280: Fix visual-replays not processing turn 0 commands., D3067: Fix visual-replays not processing turn 0 commands..

Harbormaster completed building B15349: rP24764: Revert rP24280, causing false OOS in visual replays..Jan 22 2021, 6:26 PM

Changes (2)

Path

Size

ps/

trunk/

source/

simulation2/

system/

ReplayTurnManager.cpp

ReplayTurnManager.h

rP24764

View Options

ps/trunk/source/simulation2/system/ReplayTurnManager.cpp