Diffusion 0 A.D. Public Repository rP25359

Fix some warnings.
rP25359
Actions

Tags

None

Subscribers

Description

Fix some warnings.

rP24553 added 'override' to a method in ShaderProgram.cpp. This adds it to the rest.
BinarySerializer.cpp had custom JS includes, because putting those in ScriptExtraHeaders failed. The cause is that gloox leaves "#define lookup" up. This has been reported upstream, and fixed here.
VS17 complains about an uninitialised variable, though the usage is safe.

Differential Revision: https://code.wildfiregames.com/D3916

Details

Committed

May 2 2021, 5:45 PM

Differential Revision

D3916: Fix some warnings.

Parents

rP25358: Allow implicit JS boolean -> string conversions.

Branches

Unknown

Tags

Unknown

Build Status

Buildable 17012
Build 39016: Trigger Windows Autobuild
Build 39015: Post-Commit Build	Jenkins
Build 39014: Post-Commit Build (macOS)	Jenkins

Event Timeline

wraitii committed rP25359: Fix some warnings..May 2 2021, 5:45 PM

wraitii added an edge: D3916: Fix some warnings..

Stan added a subscriber: Stan.May 2 2021, 5:56 PM

Stan added inline comments.

/ps/trunk/source/lobby/glooxwrapper/glooxwrapper.h
82	A bit too late but can this be tied to a version of gloox?

wraitii added inline comments.May 2 2021, 6:14 PM

/ps/trunk/source/lobby/glooxwrapper/glooxwrapper.h
82	Well, it could, but I can't really be sure that it'll fixed in later versions, and it won't harm on earlier versions, so I'm not sure it's worth much.

Harbormaster completed building B17012: rP25359: Fix some warnings..May 2 2021, 6:24 PM

Changes (6)

Path

Size

ps/

trunk/

source/

graphics/

ShaderProgram.cpp

lobby/

glooxwrapper/

scriptinterface/

ScriptExtraHeaders.h

simulation2/

helpers/

serialization/

BinarySerializer.h

rP25359

ps/trunk/source/graphics/ShaderProgram.cpp

Loading...

ps/trunk/source/lobby/XmppClient.cpp

Loading...

ps/trunk/source/lobby/glooxwrapper/glooxwrapper.h

Loading...

ps/trunk/source/scriptinterface/ScriptExtraHeaders.h

Loading...

ps/trunk/source/simulation2/helpers/Render.cpp

Loading...

ps/trunk/source/simulation2/serialization/BinarySerializer.h

Loading...