HomeWildfire Games
Diffusion 0 A.D. Public Repository rP25387

Fix bounding boxes after rP25306
rP25387
Actions

Description

Fix bounding boxes after rP25306

Skinning calculations must happen in bone-space.

Fixes rP25306

Reported by: langbart

Fixes #6168

Differential Revision: https://code.wildfiregames.com/D3927

Details

Auditors
Langbart
Committed
wraitiiMay 5 2021, 6:20 PM
Differential Revision
D3927: Fix bounding boxes after rP25306
Parents
rP25386: More broken implicit conversions.
Branches
Unknown
Tags
Unknown
Build Status
Buildable 17089
Build 39253: Trigger Windows Autobuild
Build 39252: Post-Commit BuildJenkins
Build 39251: Post-Commit Build (macOS)Jenkins

Event Timeline

wraitii committed rP25387: Fix bounding boxes after rP25306.May 5 2021, 6:20 PM
wraitii added an edge: D3927: Fix bounding boxes after rP25306.
Harbormaster completed building B17089: rP25387: Fix bounding boxes after rP25306.May 5 2021, 6:33 PM
Langbart raised a concern with this commit.May 6 2021, 6:16 AM
Langbart added a subscriber: Langbart.

@wraitii I tested D3927 with diff id 17396, when testing the latest SVN version the problem is back, it seems a later iteration of the patch brought back the problem.


I think it was diff ID 17400.

This commit now has outstanding concerns.May 6 2021, 6:16 AM
wraitii mentioned this in rP25391: Fix mistake in rP25387.May 6 2021, 9:43 AM
wraitii requested verification of this commit.May 6 2021, 9:45 AM
This commit now requires verification by auditors.May 6 2021, 9:45 AM
Langbart resigned from this commit.May 6 2021, 10:13 AM

I have tested rP25391 and it solves the problem.

This commit no longer requires audit.May 6 2021, 10:13 AM

Changes (3)

PathSize
ps/
trunk/
source/
graphics/

rP25387

View Options

ps/trunk/source/graphics/ModelDef.cpp

Loading...
View Options

ps/trunk/source/graphics/SkeletonAnimDef.cpp

Loading...
View Options

ps/trunk/source/graphics/SkeletonAnimDef.h

Loading...
Wildfire Games ยท Phabricator