Paths

Table of Contentst

Diffusion 0 A.D. Public Repository rP25584

Improve support for classes in PetraAI.
AuditedrP25584
Actions

Description

Improve support for classes in PetraAI.

Let PetraAI use MatchesClassList more.

Differential revision: https://code.wildfiregames.com/D2150
Reviewed by: Angen
Comments by: Stan

Details

Auditors

Stan

Committed

Freagarach

May 28 2021, 8:54 AM

Reviewer

Silier

Differential Revision

D2150: [PetraAI] - Improve support for classes.

Parents

rP25583: [Windows] Automated build.

Branches

Unknown

Tags

Unknown

Build Status

Buildable 17557
Build 40711: Post-Commit Build	Jenkins
Build 40710: Post-Commit Build (macOS)	Jenkins

Event Timeline

Freagarach committed rP25584: Improve support for classes in PetraAI..May 28 2021, 8:54 AM

Freagarach added an edge: D2150: [PetraAI] - Improve support for classes..

Harbormaster completed building B17557: rP25584: Improve support for classes in PetraAI..May 28 2021, 9:14 AM

Either causes or exposes https://wildfiregames.com/forum/topic/45178-a25-svn-version-25810-not-playable/.
I guess a concern would be in place.

↑

This commit now has outstanding concerns.Jun 29 2021, 2:43 PM

Freagarach added inline comments.Jun 29 2021, 5:23 PM

/ps/trunk/binaries/data/mods/public/simulation/ai/petra/attackPlan.js
358	Should be `+`.

Freagarach mentioned this in D4184: Fix PetraAI building a lot of siege and not using it..Jun 30 2021, 9:01 AM

D4184, but there is more, since she keeps constructing siege without using it.

Freagarach mentioned this in rP25826: (Partly) Fix PetraAI building a lot of siege and not using it..Jul 18 2021, 7:07 AM

Freagarach mentioned this in D4193: Fix PetraAI training ships as ordinary units..Jul 18 2021, 11:01 AM

Freagarach mentioned this in rP25828: Fix PetraAI constructing ships as ordinary units..Jul 20 2021, 7:20 AM

Stan accepted this commit.Jul 21 2021, 7:26 PM

All concerns with this commit have now been addressed.Jul 21 2021, 7:26 PM

Changes (17)

Path

Size

ps/

trunk/

binaries/

data/

mods/

public/

simulation/

ai/

common-api/

petra/

rP25584

View Options

ps/trunk/binaries/data/mods/public/simulation/ai/common-api/entity.js

View Options

ps/trunk/binaries/data/mods/public/simulation/ai/common-api/filters.js

View Options

ps/trunk/binaries/data/mods/public/simulation/ai/common-api/gamestate.js

View Options

ps/trunk/binaries/data/mods/public/simulation/ai/common-api/technology.js

View Options

ps/trunk/binaries/data/mods/public/simulation/ai/petra/attackManager.js

View Options

ps/trunk/binaries/data/mods/public/simulation/ai/petra/attackPlan.js

View Options

ps/trunk/binaries/data/mods/public/simulation/ai/petra/baseManager.js

View Options

ps/trunk/binaries/data/mods/public/simulation/ai/petra/buildManager.js

View Options

ps/trunk/binaries/data/mods/public/simulation/ai/petra/defenseArmy.js

View Options

ps/trunk/binaries/data/mods/public/simulation/ai/petra/defenseManager.js

View Options

ps/trunk/binaries/data/mods/public/simulation/ai/petra/entityExtend.js

View Options

ps/trunk/binaries/data/mods/public/simulation/ai/petra/garrisonManager.js

View Options

ps/trunk/binaries/data/mods/public/simulation/ai/petra/headquarters.js

View Options

ps/trunk/binaries/data/mods/public/simulation/ai/petra/navalManager.js

View Options

ps/trunk/binaries/data/mods/public/simulation/ai/petra/queueplanBuilding.js

View Options

ps/trunk/binaries/data/mods/public/simulation/ai/petra/startingStrategy.js

View Options

ps/trunk/binaries/data/mods/public/simulation/ai/petra/worker.js

Improve support for classes in PetraAI.AuditedrP25584Actions

Description

Details

Event Timeline

Changes (17)

rP25584

ps/trunk/binaries/data/mods/public/simulation/ai/common-api/entity.js

ps/trunk/binaries/data/mods/public/simulation/ai/common-api/filters.js

ps/trunk/binaries/data/mods/public/simulation/ai/common-api/gamestate.js

ps/trunk/binaries/data/mods/public/simulation/ai/common-api/technology.js

ps/trunk/binaries/data/mods/public/simulation/ai/petra/attackManager.js

ps/trunk/binaries/data/mods/public/simulation/ai/petra/attackPlan.js

ps/trunk/binaries/data/mods/public/simulation/ai/petra/baseManager.js

ps/trunk/binaries/data/mods/public/simulation/ai/petra/buildManager.js

ps/trunk/binaries/data/mods/public/simulation/ai/petra/defenseArmy.js

ps/trunk/binaries/data/mods/public/simulation/ai/petra/defenseManager.js

ps/trunk/binaries/data/mods/public/simulation/ai/petra/entityExtend.js

ps/trunk/binaries/data/mods/public/simulation/ai/petra/garrisonManager.js

ps/trunk/binaries/data/mods/public/simulation/ai/petra/headquarters.js

ps/trunk/binaries/data/mods/public/simulation/ai/petra/navalManager.js

ps/trunk/binaries/data/mods/public/simulation/ai/petra/queueplanBuilding.js

ps/trunk/binaries/data/mods/public/simulation/ai/petra/startingStrategy.js

ps/trunk/binaries/data/mods/public/simulation/ai/petra/worker.js

Improve support for classes in PetraAI.
AuditedrP25584
Actions