Paths

Table of Contentst

Diffusion 0 A.D. Public Repository rP25854

Fix updating existing mods
rP25854
Actions

Description

Fix updating existing mods

Replace wrename, that fails when mod exists already with RenameFile by @Stan
Check if mod was actually installed when downloading it
error if mod cannot be coppied into modTemp

Differential revision: D4222

Details

Committed

Silier

Aug 22 2021, 1:35 PM

Differential Revision

D4222: Fix drag and drop on executable if mod already exists

Parents

rP25853: Fix downloanded mods not showing in list until restart

Branches

Unknown

Tags

Unknown

Build Status

Buildable 18196
Build 42683: Trigger Windows Autobuild
Build 42682: Post-Commit Build	Jenkins
Build 42681: Post-Commit Build (macOS)	Jenkins

Event Timeline

Silier committed rP25854: Fix updating existing mods.Aug 22 2021, 1:35 PM

Silier added an edge: D4222: Fix drag and drop on executable if mod already exists.

Silier added a subscriber: Stan.

Harbormaster completed building B18196: rP25854: Fix updating existing mods.Aug 22 2021, 2:24 PM

Stan mentioned this in rP25855: Fix nopch build. broken in Phab:rP25854..Aug 22 2021, 3:20 PM

Stan mentioned this in D4225: Remove Custom implemenation of wrename on windows..Aug 22 2021, 3:47 PM

vladislavbelov added a subscriber: vladislavbelov.Aug 23 2021, 9:19 AM

vladislavbelov added inline comments.

/ps/trunk/source/lib/file/file_system.cpp
36	We don't need `boost` anymore, since we use C++17. It only needs to check <filesystem> on all supported platforms.

Stan mentioned this in rP25907: Remove Custom implementation of wrename on windows. Phab:rP25854 removed the….Sep 9 2021, 7:53 PM

Stan mentioned this in D4763: Fix broken rename and copy on Windows..Aug 14 2022, 5:40 PM

Stan mentioned this in rP27055: Fix mod installation in non latin folders. Use OSString for consistency. .Aug 14 2022, 7:55 PM

Changes (6)

Path

Size

ps/

trunk/

source/

lib/

file/

ps/

rP25854

View Options

ps/trunk/source/lib/file/file_system.cpp

View Options

ps/trunk/source/lib/file/file_system.h

View Options

ps/trunk/source/main.cpp

View Options

ps/trunk/source/ps/ModInstaller.cpp

View Options

ps/trunk/source/ps/ModInstaller.h

View Options

ps/trunk/source/ps/ModIo.cpp

Fix updating existing modsrP25854Actions

Description

Details

Event Timeline

Changes (6)

rP25854

ps/trunk/source/lib/file/file_system.cpp

ps/trunk/source/lib/file/file_system.h

ps/trunk/source/main.cpp

ps/trunk/source/ps/ModInstaller.cpp

ps/trunk/source/ps/ModInstaller.h

ps/trunk/source/ps/ModIo.cpp

Fix updating existing mods
rP25854
Actions