Diffusion 0 A.D. Public Repository rP26286

Moves depth and stencil tests to PipelineState and DeviceCommandContext.
rP26286
Actions

Description

Moves depth and stencil tests to PipelineState and DeviceCommandContext.

Differential Revision: https://code.wildfiregames.com/D4471

Details

Auditors

Langbart

Committed

vladislavbelov

Feb 1 2022, 5:38 PM

Differential Revision

D4471: Moves depth and stencil tests to PipelineState and DeviceCommandContext

Parents

rP26285: [Windows] Automated build.

Branches

Unknown

Tags

Unknown

Build Status

Buildable 19338
Build 46225: Trigger Windows Autobuild
Build 46224: Post-Commit Build	Jenkins
Build 46223: Post-Commit Build (macOS)	Jenkins

Event Timeline

vladislavbelov committed rP26286: Moves depth and stencil tests to PipelineState and DeviceCommandContext..Feb 1 2022, 5:38 PM

vladislavbelov added an edge: D4471: Moves depth and stencil tests to PipelineState and DeviceCommandContext.

Harbormaster failed to build B19338: rP26286: Moves depth and stencil tests to PipelineState and DeviceCommandContext.!Feb 1 2022, 5:50 PM

The minimap shows only the red polygon and blackness. #6426

This commit now has outstanding concerns.Feb 2 2022, 8:42 AM

In rP26286#55614, @Langbart wrote:

The minimap shows only the red polygon and blackness. #6426

Fixed in rP26290.

vladislavbelov mentioned this in rP26290: Disables depth test for minimap effect after rP26286. Fixes #6426.Feb 2 2022, 7:44 PM

vladislavbelov requested verification of this commit.Feb 2 2022, 7:48 PM

This commit now requires verification by auditors.Feb 2 2022, 7:48 PM

Langbart resigned from this commit.Feb 2 2022, 8:55 PM

This commit no longer requires audit.Feb 2 2022, 8:55 PM

Changes (32)

Path

Size

ps/

trunk/

binaries/

data/

mods/

mod/

shaders/

effects/

canvas2d.xml

public/

shaders/

effects/

model_transparent.xml

postproc/

source/

graphics/

renderer/

backend/

gl/

DeviceCommandContext.cpp

Mapping.cpp

Mapping.h

tools/

atlas/

GameInterface/

ActorViewer.cpp

View.cpp

rP26286

View Options

ps/trunk/binaries/data/mods/mod/shaders/effects/canvas2d.xml

View Options

ps/trunk/binaries/data/mods/public/shaders/effects/bloom.xml

View Options

ps/trunk/binaries/data/mods/public/shaders/effects/cas.xml

View Options

ps/trunk/binaries/data/mods/public/shaders/effects/debug_overlay.xml

View Options

ps/trunk/binaries/data/mods/public/shaders/effects/fxaa.xml

View Options

ps/trunk/binaries/data/mods/public/shaders/effects/model.xml

View Options

ps/trunk/binaries/data/mods/public/shaders/effects/model_transparent.xml

View Options

ps/trunk/binaries/data/mods/public/shaders/effects/postproc/DOF.xml

View Options

ps/trunk/binaries/data/mods/public/shaders/effects/postproc/hdr.xml

View Options

ps/trunk/binaries/data/mods/public/shaders/effects/water_high.xml

View Options

ps/trunk/binaries/data/mods/public/shaders/effects/water_simple.xml

View Options

ps/trunk/binaries/data/mods/public/shaders/effects/water_waves.xml

View Options

ps/trunk/source/graphics/CinemaManager.cpp

View Options

ps/trunk/source/graphics/ShaderManager.cpp

View Options

ps/trunk/source/renderer/DebugRenderer.cpp

View Options

ps/trunk/source/renderer/DebugRenderer.h

View Options

ps/trunk/source/renderer/OverlayRenderer.cpp

View Options

ps/trunk/source/renderer/PostprocManager.cpp

View Options

ps/trunk/source/renderer/Renderer.cpp

View Options

ps/trunk/source/renderer/SceneRenderer.cpp

View Options

ps/trunk/source/renderer/ShadowMap.cpp

View Options

ps/trunk/source/renderer/TerrainOverlay.cpp

View Options

ps/trunk/source/renderer/TerrainRenderer.cpp

View Options

ps/trunk/source/renderer/WaterManager.cpp

View Options

ps/trunk/source/renderer/backend/PipelineState.cpp

View Options

ps/trunk/source/renderer/backend/PipelineState.h

View Options

ps/trunk/source/renderer/backend/gl/Device.cpp

View Options

ps/trunk/source/renderer/backend/gl/DeviceCommandContext.cpp

View Options

ps/trunk/source/renderer/backend/gl/Mapping.cpp

View Options

ps/trunk/source/renderer/backend/gl/Mapping.h

View Options

ps/trunk/source/tools/atlas/GameInterface/ActorViewer.cpp

View Options

ps/trunk/source/tools/atlas/GameInterface/View.cpp

Moves depth and stencil tests to PipelineState and DeviceCommandContext.rP26286Actions

Description

Details

Event Timeline

Changes (32)

rP26286

ps/trunk/binaries/data/mods/mod/shaders/effects/canvas2d.xml

ps/trunk/binaries/data/mods/public/shaders/effects/bloom.xml

ps/trunk/binaries/data/mods/public/shaders/effects/cas.xml

ps/trunk/binaries/data/mods/public/shaders/effects/debug_overlay.xml

ps/trunk/binaries/data/mods/public/shaders/effects/fxaa.xml

ps/trunk/binaries/data/mods/public/shaders/effects/model.xml

ps/trunk/binaries/data/mods/public/shaders/effects/model_transparent.xml

ps/trunk/binaries/data/mods/public/shaders/effects/postproc/DOF.xml

ps/trunk/binaries/data/mods/public/shaders/effects/postproc/hdr.xml

ps/trunk/binaries/data/mods/public/shaders/effects/water_high.xml

ps/trunk/binaries/data/mods/public/shaders/effects/water_simple.xml

ps/trunk/binaries/data/mods/public/shaders/effects/water_waves.xml

ps/trunk/source/graphics/CinemaManager.cpp

ps/trunk/source/graphics/ShaderManager.cpp

ps/trunk/source/renderer/DebugRenderer.cpp

ps/trunk/source/renderer/DebugRenderer.h

ps/trunk/source/renderer/OverlayRenderer.cpp

ps/trunk/source/renderer/PostprocManager.cpp

ps/trunk/source/renderer/Renderer.cpp

ps/trunk/source/renderer/SceneRenderer.cpp

ps/trunk/source/renderer/ShadowMap.cpp

ps/trunk/source/renderer/TerrainOverlay.cpp

ps/trunk/source/renderer/TerrainRenderer.cpp

ps/trunk/source/renderer/WaterManager.cpp

ps/trunk/source/renderer/backend/PipelineState.cpp

ps/trunk/source/renderer/backend/PipelineState.h

ps/trunk/source/renderer/backend/gl/Device.cpp

ps/trunk/source/renderer/backend/gl/DeviceCommandContext.cpp

ps/trunk/source/renderer/backend/gl/Mapping.cpp

ps/trunk/source/renderer/backend/gl/Mapping.h

ps/trunk/source/tools/atlas/GameInterface/ActorViewer.cpp

ps/trunk/source/tools/atlas/GameInterface/View.cpp

Moves depth and stencil tests to PipelineState and DeviceCommandContext.
rP26286
Actions