Page MenuHomeWildfire Games

New formation bonus
Needs ReviewPublic

Authored by Angen on Jan 12 2018, 10:11 AM.
This revision needs review, but there are no reviewers specified.

Details

Reviewers
None
Trac Tickets
#3523
Summary

Formation itself now can have bonuses using aura system.
Example is phalanx formation, when units are in this formation, they have +20% attack melee damage.

Fix when changing formations from D756 was necessary to apply, thank you temple.

Test Plan

create phalanx - units get bonus
disband phalanx - no bonus
move unit from formation - no bonus
change formation - no bonus

Diff Detail

Repository
rP 0 A.D. Public Repository
Branch
/ps/trunk
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 4500
Build 7860: Vulcan Build
Build 7859: arc lint + arc unit

Event Timeline

Angen created this revision.Jan 12 2018, 10:11 AM
temple added a subscriber: temple.Jan 12 2018, 5:11 PM

Currently some formations have a speed bonus (<SpeedMultiplier>1.25</SpeedMultiplier>) but it's kind of mysterious since it doesn't show in the individual units' stats, instead it's a property of the formation. So maybe that bonus should should be changed to an aura.

Angen updated this revision to Diff 5332.Jan 16 2018, 1:35 PM

speed multiplier moved to formation aura

temple added a comment.EditedJan 16 2018, 9:02 PM

There are ideas for particular values here (I'm not saying if they're good or not):
https://wildfiregames.com/forum/index.php?/topic/13726-formations/

Angen added a comment.Jan 17 2018, 9:46 AM
In D1218#49847, @temple wrote:

There are ideas for particular values here (I'm not saying if they're good or not):
https://wildfiregames.com/forum/index.php?/topic/13726-formations/

Yes, but since they cannot fight as formation properly, it would be some kind of hack to give them more armour and attack bonuses now.
They spread and they are not formation anymore., why to have some attack, armour bonus.

Stan added a subscriber: Stan.Jan 17 2018, 9:57 AM

Did you upload you fix for that somewhere @Angen ? Temple is in the team now so he will be able to commit it if it's good. :)

In D1218#49902, @Stan wrote:

Did you upload you fix for that somewhere @Angen ? Temple is in the team now so he will be able to commit it if it's good. :)

If you mean formation bonus as aura, no I dont.

Stan added a comment.Jan 17 2018, 12:19 PM

No the fight in formation one

In D1218#49906, @Stan wrote:

No the fight in formation one

No, I do not have solution for that, but this patch is about to be able to have + speed change is displayed in unit stats now.

In D1218#49901, @Angen wrote:

Yes, but since they cannot fight as formation properly, it would be some kind of hack to give them more armour and attack bonuses now.
They spread and they are not formation anymore., why to have some attack, armour bonus.

Agreed, so we should save this patch for after formation attack is improved.

Angen added a comment.Mar 6 2018, 12:56 PM

@temple I was thinking again and maybe you could commit it for only speed change using auras?

temple added a comment.Mar 7 2018, 2:36 AM

We should probably remove the speed bonuses for now since there's no penalties.

Seems it was decided to hold off on this until formation attacks are mechanically practical (I agree, but wasn't sure if this still needed review), since it would be unfair if units can be physically spread apart, but still get formation bonuses.

Linked in IRC discussion today: https://github.com/Yves-G/0ad/tree/BattalionSystem

I messaged Yves to see where he's at on that git branch. If we don't hear back or he's unable to resume work, we can evaluate it as a WIP.