Rome Testudo & Anti-Cavalry formations animations:
Reviewed by Stan
I'd first salute the artwork.
So I hesitated to post something here and I wondered if I was the only one to notice some weird visual.
Is there something wrong in the animation (or in the code?), I have the anti_cavalry formation walking then sometimes putting knees on the ground and standing up doing some kind of squat.
edit: pinging the author @Alexandermb
The formation should remain with the animation when idle but due to code in formations they don't remain with the formation animation idle_variant for example see also the testudo wich should remain as a turtle or the macedonian Syntagma.
Formations code needs to replace the default_variant with formation_variant until the formation is disbanded.
I wanted to see the squat, but I didn't test the repository of this commit, perhaps I missed 0ad dank meme material.
Testing with r22393 revealed some bugs, but they are probably not related to this commit (a segfault and units often not attacking anymore).
So "Requires 16 Spear Infantry Soldiers." or similar would be more precise.
As noted on IRC, this triggers an infinite loop in JS (so contrary to what said above, the segfault is related), because of some unknown (so far) issue with attacking as formation (which was removed by D1220 otherwise).
I don't think we can sanely guarantee that attack-as-formation works right now, even if this particular case may be fixable - so it should probably be changed.