Rome Testudo & Anti-Cavalry formations animations:
Reviewed by Stan
Rome Testudo & Anti-Cavalry formations animations: Tags None Tokens
Description
Details
Event TimelineComment Actions
If there's a forum link, would be useful to add it to the commit message.
Comment Actions I'd first salute the artwork. edit: pinging the author @Alexandermb Comment Actions I will assume I am not the only one to have test it so it's probably my computer which does something weird. Comment Actions @Alexandermb is working on quite some stuff right now so he probably missed it :) You know how fast things go around here :) Comment Actions The formation should remain with the animation when idle but due to code in formations they don't remain with the formation animation idle_variant for example see also the testudo wich should remain as a turtle or the macedonian Syntagma. Formations code needs to replace the default_variant with formation_variant until the formation is disbanded. Comment Actions I wanted to see the squat, but I didn't test the repository of this commit, perhaps I missed 0ad dank meme material.
Comment Actions As noted on IRC, this triggers an infinite loop in JS (so contrary to what said above, the segfault is related), because of some unknown (so far) issue with attacking as formation (which was removed by D1220 otherwise). I don't think we can sanely guarantee that attack-as-formation works right now, even if this particular case may be fixable - so it should probably be changed. Comment Actions Ah, that explains why there was no formation which could attack as formation whilst testing D1971 ;) Comment Actions
|