Should return something according to the name

Sure we should fill the cache in advance and not just in time?

GetEntityStates

Could be a return ents.map(ent => ({ prop1: val1, \n prop2: val2 }));

Yes, i hesitated to call it LoadMultiEntityStates for that purpose, but then keep the GetMultiEntityStates by symetry with the other function. I can a return (which is not currently used) or change the name, as preferred.

We can also do nothing (entityStates will be called when needed). As this is used only when the selection changes, that's does not affect performances. So we can remove that line here.

As the function GetEntityState still exists, that would be too confusing. So I'd rather keep the multi here, or rename the function to LoadEntityStates (as discussed in previous comment).

ok

I'd prefer a Get*EntityState* name and add a return. There might be a use-case in the future, symmetry is nice and there is no real cost (only returns a reference to the object)

Hm, actually the call should help with performance as the just-in-time loading does one call per entity rather than one call for all entities. So keep it, it's good.

(same)

+ple? :-)

Why not GetMultipleEntityStates?

Why not GetMultipleEntityStatesand then remove the null ones?

I thought a for loop is faster than map?
(Maybe it doesn't matter that much here...)

Maybe add a comment, why we do this here?

Thought about it too, but doesn't really shorten.

And a counted loop is much faster than a for...of loop. https://code.wildfiregames.com/rP20706#26324
The question is if the relation of the performance of the loop to the performance of the rest.

My guess is that, at that point, GetEntityState(ent) has already been called for all entities of the selection and we (nearly always) only need to check that it was not null (i.e. that the entity has not been already destroyed).
If calling GetMultipleEntityStates, we'd need first to check that GetEntityState(ent) is not already filled (i.e. a filter like when the selection changes) and then check the GetEntityState is not null for each ent. So not shorter.

As before, when you are here, GetMultipleEntityStates has already been called, so all entityStates are already in g_EntityStates. You only need to remove those which are null, not to do the Engine;GuiInterfaceCall which is the role of GetMultipleEntityStates.

you mean the filter? just because the new selection can contain a subset of the previous one, and we don't want to re-transfer all the common entityStates. I can add a comment if not clear enough.

yes, this loop on ents here is negligible compared to the time to collect all the entities info, and more importantly to pass that info from js to c++ then js back. So i've favored code shorteness here.