/ps/trunk/binaries/data/mods/public/gui/session/session.js
202	`GetMultipleEntityStates` can return null, but null can't be frozen. As reported by temple, this throws an error in some situations (presumably when having an entity selected that got destroyed). Could just make that `g_EntityStates[item.entId] = item.state && deepfreeze(item.state);` https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Operators/Logical_Operators && Returns expr1 if it can be converted to false; otherwise, returns expr2.

mimo mentioned this in rP20885: fix rP20875.Jan 16 2018, 9:29 AM

elexis added inline comments.Jan 16 2018, 5:21 PM

/ps/trunk/binaries/data/mods/public/gui/session/session.js
790	The code in Imaroks multi-selection patch primarily uses `entStates.some`. So if 200 units are selected and and all loops abort after the first `some` iteration, the 199 other entity states were not be used in that code part. Whether this scenario is actually occuring depends on the entity templates and the most recent fancy multi-selection GUI features. Just wanted to say that the GetEntityState function will always remain subject to optimization and revision as long as it's low performant. (It would be nice if the tooltip functions could specify themselves which info they will need and then acquire exactly the used properties in the GUI interface)

temple raised a concern with this commit.Jan 16 2018, 11:19 PM

temple added a subscriber: temple.

temple added inline comments.

/ps/trunk/binaries/data/mods/public/simulation/components/GuiInterface.js

363–364

These used to be in the regular interface rather than miraged, so now when selecting we get:

ERROR: JavaScript error: simulation/components/GuiInterface.js line 363
TypeError: cmpFoundation.GetBuildRate is not a function
  GuiInterface.prototype.GetEntityState@simulation/components/GuiInterface.js:363:19

371

Same, I assume.

This commit now has outstanding concerns.Jan 16 2018, 11:19 PM

Yes, thanks for the report. I'll have a look.

See D1230

mimo mentioned this in rP20938: fix miraged properties in GuiInterface changes from rP20875.Jan 20 2018, 4:09 PM

temple accepted this commit.Jan 23 2018, 5:45 PM

All concerns with this commit have now been addressed.Jan 23 2018, 5:45 PM