Cleaning the code

With this patch we are enabled to extend the PlayerColor control in game setup but also enabled from mod to extend for more color. this patch doesnt affect anything else and remove dependencies from other components

Hi Ivy, first at all thx for help to improve different stuff in atlas.

Is there any objection?, Im going to push this ticket if we dont have any other objection.

Added missing endling line

Use "const" instead of "var"

Well in my case MSBuild.exe doesnt exists in PATH, thats why I use this script, but you can use "last" instead of "first" or something different because we need to use toolset that allow to build xp suport build.

Stan I was testing the script and I would suggest this:

this implementaiton allow to have a json file with colors,
also I used g_Settings to have this information in consistency way

Use a different Implementation.

this patch allow to have more color in match setup but also fix a bug find by Vladislav in Atlas

New Diff with context in the patch

Fixing problem (different line endings).

In this patch I'm trying to fix the next use cases:

In D2042#124775, @Angen wrote:

First, this is great feature to have. But it needs a bit of work.

1.) It should be possible to set none variant in a group as in some cases they compete with variants of other groups and one will never see the variants from another groups.
2.) Variant menu needs to be visible in actor viewer too as mostly that is the place where people try animations and stuff.

Update patch with the current version.
When an empty selection hide combobox in variation panel
Change space in object panel to use 50% space

in my osx Catalino works pretty well, I think the only thing is to add arguments.

In D2752#123195, @trompetin17 wrote:

@wraitii with your patch when start atlas I see a black window in the right hand, is this for "RendererIncrementalLoad"?

Hi, I tried this path, I saw something interesting in my processor, it was always in 20% and this happen only starting.

Add validation on childActors, it must have one child

change null for nullptr

tested in mojave

remove space

this patch also solve more cleaner this https://trac.wildfiregames.com/ticket/3089
There is a patch but adding a new button, with this I can select, change tool, select the same template and add it.

Remove backspace

Change atribute variations to node element

Fixing missing cpp

remove listViewItemId, and Item.setWidth

Fixing unit.h to Unit.h, remove some braces

Update Copyright

remove not needed braces for one command after if condition,

Fixing std::string initialize and check empty

Tested on OSX Mojave

I need to know if we could commit this one, Im going to continue with the other bugs like this one _createMenuRef called with existing principal MenuRef already associated with menu.

Hi wraitti please review comments in this revision
https://code.wildfiregames.com/rP22023#34567

I want to add more evidence in this ticket about the problem and what get this error!

Finxing Typo

Fixed Typo

Change VIsual Setting

Fix messages description

Add "trigger" Keyword in Map settings
Change Checkbox to be 2 by line

I rebuild libcurl and game, I was able to join in lobby, open mod.io

I tried today and when i tried to build the game It gave me a error:

"clock_gettime" isnt implemented in osx until 10.12, so we need a way to emulate this function from 10.9 to 10.11

Remove -mmacosx-version-min like itms suggest, and update to use osx 10.9

Hello, I tested this patch over osx mojave, I made the bundle and play over it.

Just an idea, could we add code in osx about include explicitly at run time Metal Lib is you already have, because SDL2.0.9 check witch use depending on osx, isnt?

Added environment variable instead hardcode version.

Itms, could you point me where do you see about drop 10.9 to 10.11, because when i tried sdl2.0.9 i didnt change minimal osx version and builded normally

In D1669#66044, @Itms wrote:

Yes, like Vlad says, we should change our own defaults in the premake scripts, but we mustn't touch premake source (it's easier to maintain when we match upstream).