Page MenuHomeWildfire Games
Differential D1246

Allow to lock teams in scenarios
Needs ReviewPublic
Actions

Authored by mimo on Jan 22 2018, 6:48 PM.
Tags
None
Referenced Files
F5210338: D1246.diff
Fri, Sep 20, 8:23 AM
Unknown Object (File)
Fri, Sep 13, 1:43 PM
Unknown Object (File)
Fri, Sep 13, 1:28 PM
Unknown Object (File)
Fri, Sep 13, 12:16 PM
Unknown Object (File)
Fri, Sep 6, 7:52 AM
Unknown Object (File)
Thu, Sep 5, 10:56 AM
Subscribers
elexis
historic_bruno
Restricted Owners Package
This revision needs review, but there are no reviewers specified.

Details

Reviewers
None
Summary

see discussion on #4817

Test Plan

check that the patch does what it is supposed to do

Diff Detail

Event Timeline

mimo created this revision.Jan 22 2018, 6:48 PM
Owners added a subscriber: Restricted Owners Package.Jan 22 2018, 6:48 PM
Harbormaster failed remote builds in B4615: Diff 5424!Jan 22 2018, 6:49 PM
elexis added a subscriber: elexis.Feb 19 2018, 5:38 PM

I'm reluctant with this. The idea of scenario maps must have been at one point to let the map lock every setting.
But Im not sure anymore if we can't delete the maptype altogether eventually and let every map support or not support any property.
Then it would remain consistent for all properties.

historic_bruno added a subscriber: historic_bruno.Jul 19 2019, 7:14 AM
In D1246#53684, @elexis wrote:

I'm reluctant with this. The idea of scenario maps must have been at one point to let the map lock every setting.

Exactly. Team/diplomacy settings weren't supposed to change at all. It's a scenario after all, so if there are teams, that is enforced by the scenario config.

elexis mentioned this in D2483: Gamesetup class rewrite.Dec 18 2019, 5:49 PM

Revision Contents
Changeset List

PathSize
binaries/
data/
mods/
public/
gui/
gamesetup/
4 lines

Diff 5424

View Options

binaries/data/mods/public/gui/gamesetup/gamesetup.js

Loading...
Wildfire Games · Phabricator