Page MenuHomeWildfire Games
Differential D1295

Clean up the updateBandbox function
ClosedPublic
Actions

Authored by OptimusShepard on Feb 11 2018, 2:15 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Sep 28, 5:30 AM
Unknown Object (File)
Mon, Sep 23, 10:58 PM
Unknown Object (File)
Sun, Sep 22, 7:55 AM
Unknown Object (File)
Tue, Sep 10, 5:25 AM
Unknown Object (File)
Fri, Sep 6, 7:40 PM
Unknown Object (File)
Wed, Sep 4, 11:30 AM
Unknown Object (File)
Mon, Sep 2, 10:39 AM
Subscribers
bb
Vulcan
Restricted Owners Package

Details

Reviewers
elexis
bb
Commits
rP21185: Cleanup updateBandbox function with using vector functions
Summary

add some vector functions
see D1288

Test Plan

test the bandBox

Diff Detail

Repository
rP 0 A.D. Public Repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

OptimusShepard created this revision.Feb 11 2018, 2:15 PM
Vulcan added a subscriber: Vulcan.Feb 11 2018, 2:17 PM

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/differential/5/display/redirect

Harbormaster completed remote builds in B4917: Diff 5762.Feb 11 2018, 2:17 PM
OptimusShepard updated this revision to Diff 5763.Feb 11 2018, 2:24 PM

update the comments

Vulcan added a comment.Feb 11 2018, 2:26 PM

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/differential/6/display/redirect

Harbormaster completed remote builds in B4918: Diff 5763.Feb 11 2018, 2:26 PM
bb accepted this revision.Feb 12 2018, 12:21 PM
bb added a subscriber: bb.

Code should do the same, testing says it is ok

binaries/data/mods/public/gui/session/input.js
353 ↗(On Diff #5763)

"Returns the coordinates of the vertices." or even better "@returns {array} The coordinates of the vertices."

This revision is now accepted and ready to land.Feb 12 2018, 12:21 PM
Closed by commit rP21185: Cleanup updateBandbox function with using vector functions (authored by bb). · Explain WhyFeb 12 2018, 12:41 PM
This revision was automatically updated to reflect the committed changes.
Owners added a subscriber: Restricted Owners Package.Feb 12 2018, 12:41 PM
elexis added a comment.Feb 13 2018, 2:58 PM

Thanks for the patch and review Optimus and bb!

OptimusShepard added a comment.Feb 13 2018, 9:51 PM

thx for reviewing

Revision Contents
Changeset List

PathSize
ps/
trunk/
binaries/
data/
mods/
public/
gui/
session/
30 lines

Diff 5773

View Options

ps/trunk/binaries/data/mods/public/gui/session/input.js

Loading...
Wildfire Games · Phabricator