Page MenuHomeWildfire Games

Update NULL to nullptr
Needs ReviewPublic

Authored by Angen on Nov 10 2018, 1:45 PM.
This revision needs review, but there are no reviewers specified.

Details

Reviewers
None
Summary

NULL -> nullptr
and 0 -> nullptr in delete macros

Test Plan

:)

Diff Detail

Repository
rP 0 A.D. Public Repository
Branch
/ps/trunk
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 6447
Build 10679: Vulcan BuildJenkins
Build 10678: arc lint + arc unit

Event Timeline

Angen created this revision.Nov 10 2018, 1:45 PM
Owners added subscribers: Restricted Owners Package, Restricted Owners Package, Restricted Owners Package.Nov 10 2018, 1:45 PM
Vulcan added a subscriber: Vulcan.Nov 10 2018, 2:31 PM

Successful build - Chance fights ever on the side of the prudent.

Linter detected issues:
Executing section Default...
Executing section Source...

source/lib/tests/test_secure_crt.h
| 140| »   »   strcpy(dst,·dst_val);
|    | [MAJOR] CPPCheckBear (bufferAccessOutOfBounds):
|    | Buffer is accessed out of bounds: d1

source/lib/tests/test_secure_crt.h
| 150| »   »   strcpy(dst,·dst_val);
|    | [MAJOR] CPPCheckBear (bufferAccessOutOfBounds):
|    | Buffer is accessed out of bounds: d1

source/lib/tests/test_secure_crt.h
| 140| »   »   strcpy(dst,·dst_val);
|    | [MAJOR] CPPCheckBear (bufferAccessOutOfBounds):
|    | Buffer is accessed out of bounds: d3

source/lib/tests/test_secure_crt.h
| 150| »   »   strcpy(dst,·dst_val);
|    | [MAJOR] CPPCheckBear (bufferAccessOutOfBounds):
|    | Buffer is accessed out of bounds: d3

source/lib/tests/test_secure_crt.h
| 140| »   »   strcpy(dst,·dst_val);
|    | [MAJOR] CPPCheckBear (bufferAccessOutOfBounds):
|    | Buffer is accessed out of bounds: d5

source/lib/tests/test_secure_crt.h
| 150| »   »   strcpy(dst,·dst_val);
|    | [MAJOR] CPPCheckBear (bufferAccessOutOfBounds):
|    | Buffer is accessed out of bounds: d5

source/tools/atlas/GameInterface/Handlers/MiscHandlers.cpp
|  33| #include·"ps/Util.h"
|    | [MAJOR] CPPCheckBear (syntaxError):
|    | Invalid number of character ({) when these macros are defined: ''.

source/tools/atlas/GameInterface/Handlers/MiscHandlers.cpp
|  33| #include·"ps/Util.h"
|    | [MAJOR] CPPCheckBear (syntaxError):
|    | Invalid number of character ({) when these macros are defined: 'MESSAGES_SKIP_STRUCTS'.

source/tools/atlas/GameInterface/Handlers/MiscHandlers.cpp
|  33| #include·"ps/Util.h"
|    | [MAJOR] CPPCheckBear (syntaxError):
|    | Invalid number of character ({) when these macros are defined: '_MSC_VER'.

source/tools/atlas/GameInterface/Handlers/TerrainHandlers.cpp
|  33| #include·"simulation2/components/ICmpPathfinder.h"
|    | [MAJOR] CPPCheckBear (syntaxError):
|    | Invalid number of character ({) when these macros are defined: ''.

source/tools/atlas/GameInterface/Handlers/TerrainHandlers.cpp
|  33| #include·"simulation2/components/ICmpPathfinder.h"
|    | [MAJOR] CPPCheckBear (syntaxError):
|    | Invalid number of character ({) when these macros are defined: 'MESSAGES_SKIP_STRUCTS'.

source/tools/atlas/GameInterface/Handlers/TerrainHandlers.cpp
|  33| #include·"simulation2/components/ICmpPathfinder.h"
|    | [MAJOR] CPPCheckBear (syntaxError):
|    | Invalid number of character ({) when these macros are defined: '_MSC_VER'.

source/tools/atlas/GameInterface/GameLoop.cpp
|  33| #include·"lib/app_hooks.h"
|    | [MAJOR] CPPCheckBear (syntaxError):
|    | Invalid number of character ({) when these macros are defined: ''.

source/tools/atlas/GameInterface/GameLoop.cpp
|  33| #include·"lib/app_hooks.h"
|    | [MAJOR] CPPCheckBear (syntaxError):
|    | Invalid number of character ({) when these macros are defined: 'MESSAGES_SKIP_STRUCTS'.

source/tools/atlas/GameInterface/GameLoop.cpp
|  33| #include·"lib/app_hooks.h"
|    | [MAJOR] CPPCheckBear (syntaxError):
|    | Invalid number of character ({) when these macros are defined: '_MSC_VER'.

source/tools/atlas/GameInterface/View.cpp
|  33| #include·"lib/utf8.h"
|    | [MAJOR] CPPCheckBear (syntaxError):
|    | Invalid number of character ({) when these macros are defined: ''.

source/tools/atlas/GameInterface/View.cpp
|  33| #include·"lib/utf8.h"
|    | [MAJOR] CPPCheckBear (syntaxError):
|    | Invalid number of character ({) when these macros are defined: 'CONFIG2_GLES'.

source/tools/atlas/GameInterface/View.cpp
|  33| #include·"lib/utf8.h"
|    | [MAJOR] CPPCheckBear (syntaxError):
|    | Invalid number of character ({) when these macros are defined: 'MESSAGES_SKIP_STRUCTS'.

source/tools/atlas/GameInterface/View.cpp
|  33| #include·"lib/utf8.h"
|    | [MAJOR] CPPCheckBear (syntaxError):
|    | Invalid number of character ({) when these macros are defined: '_MSC_VER'.

source/tools/atlas/GameInterface/Handlers/MapHandlers.cpp
|  33| #include·"lib/file/vfs/vfs_path.h"
|    | [MAJOR] CPPCheckBear (syntaxError):
|    | Invalid number of character ({) when these macros are defined: ''.

source/tools/atlas/GameInterface/Handlers/MapHandlers.cpp
|  33| #include·"lib/file/vfs/vfs_path.h"
|    | [MAJOR] CPPCheckBear (syntaxError):
|    | Invalid number of character ({) when these macros are defined: 'MESSAGES_SKIP_STRUCTS'.

source/tools/atlas/GameInterface/Handlers/MapHandlers.cpp
|  33| #include·"lib/file/vfs/vfs_path.h"
|    | [MAJOR] CPPCheckBear (syntaxError):
|    | Invalid number of character ({) when these macros are defined: '_MSC_VER'.

source/simulation2/components/tests/test_TerritoryManager.h
| 136| »   »   TS_ASSERT_EQUALS(onesOuter->points.size(),·20U);
|    | [MAJOR] CPPCheckBear (deadpointer):
|    | Dead pointer usage. Pointer 'onesOuter' is dead if it has been assigned '&boundary' at line 96.

source/simulation2/components/tests/test_TerritoryManager.h
| 137| »   »   TS_ASSERT_EQUALS(onesInner0->points.size(),·4U);
|    | [MAJOR] CPPCheckBear (deadpointer):
|    | Dead pointer usage. Pointer 'onesInner0' is dead if it has been assigned '&boundary' at line 105.

source/simulation2/components/tests/test_TerritoryManager.h
| 138| »   »   TS_ASSERT_EQUALS(onesInner2->points.size(),·4U);
|    | [MAJOR] CPPCheckBear (deadpointer):
|    | Dead pointer usage. Pointer 'onesInner2' is dead if it has been assigned '&boundary' at line 110.

source/simulation2/components/tests/test_TerritoryManager.h
| 139| »   »   TS_ASSERT_EQUALS(twosOuter->points.size(),·4U);
|    | [MAJOR] CPPCheckBear (deadpointer):
|    | Dead pointer usage. Pointer 'twosOuter' is dead if it has been assigned '&boundary' at line 116.

source/simulation2/components/tests/test_TerritoryManager.h
| 140| »   »   TS_ASSERT_EQUALS(threesOuter->points.size(),·4U);
|    | [MAJOR] CPPCheckBear (deadpointer):
|    | Dead pointer usage. Pointer 'threesOuter' is dead if it has been assigned '&boundary' at line 121.

source/simulation2/components/tests/test_TerritoryManager.h
| 151| »   »   TestBoundaryPointsEqual(onesOuter->points,·onesOuterExpectedPoints);
|    | [MAJOR] CPPCheckBear (deadpointer):
|    | Dead pointer usage. Pointer 'onesOuter' is dead if it has been assigned '&boundary' at line 96.

source/simulation2/components/tests/test_TerritoryManager.h
| 152| »   »   TestBoundaryPointsEqual(onesInner0->points,·onesInner0ExpectedPoints);
|    | [MAJOR] CPPCheckBear (deadpointer):
|    | Dead pointer usage. Pointer 'onesInner0' is dead if it has been assigned '&boundary' at line 105.

source/simulation2/components/tests/test_TerritoryManager.h
| 153| »   »   TestBoundaryPointsEqual(onesInner2->points,·onesInner2ExpectedPoints);
|    | [MAJOR] CPPCheckBear (deadpointer):
|    | Dead pointer usage. Pointer 'onesInner2' is dead if it has been assigned '&boundary' at line 110.

source/simulation2/components/tests/test_TerritoryManager.h
| 154| »   »   TestBoundaryPointsEqual(twosOuter->points,·twosOuterExpectedPoints);
|    | [MAJOR] CPPCheckBear (deadpointer):
|    | Dead pointer usage. Pointer 'twosOuter' is dead if it has been assigned '&boundary' at line 116.

source/simulation2/components/tests/test_TerritoryManager.h
| 155| »   »   TestBoundaryPointsEqual(threesOuter->points,·threesOuterExpectedPoints);
|    | [MAJOR] CPPCheckBear (deadpointer):
|    | Dead pointer usage. Pointer 'threesOuter' is dead if it has been assigned '&boundary' at line 121.

source/simulation2/components/tests/test_TerritoryManager.h
| 217| »   »   TS_ASSERT_EQUALS(onesOuter->points.size(),·8U);
|    | [MAJOR] CPPCheckBear (deadpointer):
|    | Dead pointer usage. Pointer 'onesOuter' is dead if it has been assigned '&boundary' at line 187.

source/simulation2/components/tests/test_TerritoryManager.h
| 218| »   »   TS_ASSERT_EQUALS(twosOuter->points.size(),·22U);
|    | [MAJOR] CPPCheckBear (deadpointer):
|    | Dead pointer usage. Pointer 'twosOuter' is dead if it has been assigned '&boundary' at line 198.

source/simulation2/components/tests/test_TerritoryManager.h
| 219| »   »   TS_ASSERT_EQUALS(twosInner->points.size(),·14U);
|    | [MAJOR] CPPCheckBear (deadpointer):
|    | Dead pointer usage. Pointer 'twosInner' is dead if it has been assigned '&boundary' at line 200.

source/simulation2/components/tests/test_TerritoryManager.h
| 220| »   »   TS_ASSERT_EQUALS(threesOuter->points.size(),·14U);
|    | [MAJOR] CPPCheckBear (deadpointer):
|    | Dead pointer usage. Pointer 'threesOuter' is dead if it has been assigned '&boundary' at line 192.

source/simulation2/components/tests/test_TerritoryManager.h
| 226| »   »   if·(twosOuter->points.size()·<·twosInner->points.size())
|    | [MAJOR] CPPCheckBear (deadpointer):
|    | Dead pointer usage. Pointer 'twosOuter' is dead if it has been assigned '&boundary' at line 198.

source/simulation2/components/tests/test_TerritoryManager.h
| 226| »   »   if·(twosOuter->points.size()·<·twosInner->points.size())
|    | [MAJOR] CPPCheckBear (deadpointer):
|    | Dead pointer usage. Pointer 'twosInner' is dead if it has been assigned '&boundary' at line 200.

source/simulation2/components/tests/test_TerritoryManager.h
| 243| »   »   TestBoundaryPointsEqual(onesOuter->points,·onesOuterExpectedPoints);
|    | [MAJOR] CPPCheckBear (deadpointer):
|    | Dead pointer usage. Pointer 'onesOuter' is dead if it has been assigned '&boundary' at line 187.

source/simulation2/components/tests/test_TerritoryManager.h
| 246| »   »   TestBoundaryPointsEqual(threesOuter->points,·threesOuterExpectedPoints);
|    | [MAJOR] CPPCheckBear (deadpointer):
|    | Dead pointer usage. Pointer 'threesOuter' is dead if it has been assigned '&boundary' at line 192.

source/tools/atlas/GameInterface/ActorViewer.cpp
|  33| #include·"graphics/Terrain.h"
|    | [MAJOR] CPPCheckBear (syntaxError):
|    | Invalid number of character ({) when these macros are defined: ''.

source/tools/atlas/GameInterface/ActorViewer.cpp
|  33| #include·"graphics/Terrain.h"
|    | [MAJOR] CPPCheckBear (syntaxError):
|    | Invalid number of character ({) when these macros are defined: 'MESSAGES_SKIP_STRUCTS'.

source/tools/atlas/GameInterface/ActorViewer.cpp
|  33| #include·"graphics/Terrain.h"
|    | [MAJOR] CPPCheckBear (syntaxError):
|    | Invalid number of character ({) when these macros are defined: '_MSC_VER'.

source/tools/atlas/GameInterface/MessagesSetup.h
|  33| {
|    | [MAJOR] CPPCheckBear (syntaxError):
|    | Invalid number of character ({) when these macros are defined: ''.

source/tools/atlas/GameInterface/MessagesSetup.h
|  33| {
|    | [MAJOR] CPPCheckBear (syntaxError):
|    | Invalid number of character ({) when these macros are defined: '_MSC_VER'.

source/tools/atlas/GameInterface/MessagePasserImpl.cpp
|  33| :·m_Trace(false),·m_Semaphore(nullptr)
|    | [MAJOR] CPPCheckBear (syntaxError):
|    | Invalid number of character ({) when these macros are defined: ''.

source/tools/atlas/GameInterface/MessagePasserImpl.cpp
|  33| :·m_Trace(false),·m_Semaphore(nullptr)
|    | [MAJOR] CPPCheckBear (syntaxError):
|    | Invalid number of character ({) when these macros are defined: 'MESSAGES_SKIP_STRUCTS'.

source/tools/atlas/GameInterface/MessagePasserImpl.cpp
|  33| :·m_Trace(false),·m_Semaphore(nullptr)
|    | [MAJOR] CPPCheckBear (syntaxError):
|    | Invalid number of character ({) when these macros are defined: '_MSC_VER'.

source/tools/atlas/GameInterface/Handlers/CommandHandlers.cpp
|  33| »   »   c·=·(it->second)(msg->data);
|    | [MAJOR] CPPCheckBear (syntaxError):
|    | Invalid number of character ({) when these macros are defined: ''.

source/tools/atlas/GameInterface/Handlers/CommandHandlers.cpp
|  33| »   »   c·=·(it->second)(msg->data);
|    | [MAJOR] CPPCheckBear (syntaxError):
|    | Invalid number of character ({) when these macros are defined: 'MESSAGES_SKIP_STRUCTS'.

source/tools/atlas/GameInterface/Handlers/CommandHandlers.cpp
|  33| »   »   c·=·(it->second)(msg->data);
|    | [MAJOR] CPPCheckBear (syntaxError):
|    | Invalid number of character ({) when these macros are defined: '_MSC_VER'.

source/tools/atlas/GameInterface/Handlers/GraphicsSetupHandlers.cpp
|  33| #include·"ps/Game.h"
|    | [MAJOR] CPPCheckBear (syntaxError):
|    | Invalid number of character ({) when these macros are defined: ''.

source/tools/atlas/GameInterface/Handlers/GraphicsSetupHandlers.cpp
|  33| #include·"ps/Game.h"
|    | [MAJOR] CPPCheckBear (syntaxError):
|    | Invalid number of character ({) when these macros are defined: 'MESSAGES_SKIP_STRUCTS'.

source/tools/atlas/GameInterface/Handlers/GraphicsSetupHandlers.cpp
|  33| #include·"ps/Game.h"
|    | [MAJOR] CPPCheckBear (syntaxError):
|    | Invalid number of character ({) when these macros are defined: 'OS_MACOSX'.

source/tools/atlas/GameInterface/Handlers/GraphicsSetupHandlers.cpp
|  33| #include·"ps/Game.h"
|    | [MAJOR] CPPCheckBear (syntaxError):
|    | Invalid number of character ({) when these macros are defined: 'OS_WIN'.

source/tools/atlas/GameInterface/Handlers/GraphicsSetupHandlers.cpp
|  33| #include·"ps/Game.h"
|    | [MAJOR] CPPCheckBear (syntaxError):
|    | Invalid number of character ({) when these macros are defined: '_MSC_VER'.

source/ps/scripting/JSInterface_Debug.cpp
|  43| »   return·*(volatile·int*)0;
|    | [MAJOR] CPPCheckBear (nullPointer):
|    | Null pointer dereference

source/tools/atlas/GameInterface/View.h
|  33| 
|    | [MAJOR] CPPCheckBear (syntaxError):
|    | Invalid number of character ({) when these macros are defined: ''.

source/tools/atlas/GameInterface/View.h
|  33| 
|    | [MAJOR] CPPCheckBear (syntaxError):
|    | Invalid number of character ({) when these macros are defined: 'MESSAGES_SKIP_STRUCTS'.

source/tools/atlas/GameInterface/View.h
|  33| 
|    | [MAJOR] CPPCheckBear (syntaxError):
|    | Invalid number of character ({) when these macros are defined: '_MSC_VER'.
Executing section JS...

Link to build: https://jenkins.wildfiregames.com/job/differential/779/

Angen updated this revision to Diff 6982.Nov 10 2018, 4:56 PM

Update years and revert third party files

Successful build - Chance fights ever on the side of the prudent.

Linter detected issues:
Executing section Default...
Executing section Source...

source/tools/atlas/GameInterface/MessagesSetup.h
|  33| {
|    | [MAJOR] CPPCheckBear (syntaxError):
|    | Invalid number of character ({) when these macros are defined: ''.

source/tools/atlas/GameInterface/MessagesSetup.h
|  33| {
|    | [MAJOR] CPPCheckBear (syntaxError):
|    | Invalid number of character ({) when these macros are defined: '_MSC_VER'.

source/tools/atlas/GameInterface/Handlers/MapHandlers.cpp
|  33| #include·"lib/file/vfs/vfs_path.h"
|    | [MAJOR] CPPCheckBear (syntaxError):
|    | Invalid number of character ({) when these macros are defined: ''.

source/tools/atlas/GameInterface/Handlers/MapHandlers.cpp
|  33| #include·"lib/file/vfs/vfs_path.h"
|    | [MAJOR] CPPCheckBear (syntaxError):
|    | Invalid number of character ({) when these macros are defined: 'MESSAGES_SKIP_STRUCTS'.

source/tools/atlas/GameInterface/Handlers/MapHandlers.cpp
|  33| #include·"lib/file/vfs/vfs_path.h"
|    | [MAJOR] CPPCheckBear (syntaxError):
|    | Invalid number of character ({) when these macros are defined: '_MSC_VER'.

source/tools/atlas/GameInterface/ActorViewer.cpp
|  33| #include·"graphics/Terrain.h"
|    | [MAJOR] CPPCheckBear (syntaxError):
|    | Invalid number of character ({) when these macros are defined: ''.

source/tools/atlas/GameInterface/ActorViewer.cpp
|  33| #include·"graphics/Terrain.h"
|    | [MAJOR] CPPCheckBear (syntaxError):
|    | Invalid number of character ({) when these macros are defined: 'MESSAGES_SKIP_STRUCTS'.

source/tools/atlas/GameInterface/ActorViewer.cpp
|  33| #include·"graphics/Terrain.h"
|    | [MAJOR] CPPCheckBear (syntaxError):
|    | Invalid number of character ({) when these macros are defined: '_MSC_VER'.

source/tools/atlas/GameInterface/MessagePasserImpl.cpp
|  33| :·m_Trace(false),·m_Semaphore(nullptr)
|    | [MAJOR] CPPCheckBear (syntaxError):
|    | Invalid number of character ({) when these macros are defined: ''.

source/tools/atlas/GameInterface/MessagePasserImpl.cpp
|  33| :·m_Trace(false),·m_Semaphore(nullptr)
|    | [MAJOR] CPPCheckBear (syntaxError):
|    | Invalid number of character ({) when these macros are defined: 'MESSAGES_SKIP_STRUCTS'.

source/tools/atlas/GameInterface/MessagePasserImpl.cpp
|  33| :·m_Trace(false),·m_Semaphore(nullptr)
|    | [MAJOR] CPPCheckBear (syntaxError):
|    | Invalid number of character ({) when these macros are defined: '_MSC_VER'.

source/lib/tests/test_secure_crt.h
| 140| »   »   strcpy(dst,·dst_val);
|    | [MAJOR] CPPCheckBear (bufferAccessOutOfBounds):
|    | Buffer is accessed out of bounds: d1

source/lib/tests/test_secure_crt.h
| 150| »   »   strcpy(dst,·dst_val);
|    | [MAJOR] CPPCheckBear (bufferAccessOutOfBounds):
|    | Buffer is accessed out of bounds: d1

source/lib/tests/test_secure_crt.h
| 140| »   »   strcpy(dst,·dst_val);
|    | [MAJOR] CPPCheckBear (bufferAccessOutOfBounds):
|    | Buffer is accessed out of bounds: d3

source/lib/tests/test_secure_crt.h
| 150| »   »   strcpy(dst,·dst_val);
|    | [MAJOR] CPPCheckBear (bufferAccessOutOfBounds):
|    | Buffer is accessed out of bounds: d3

source/lib/tests/test_secure_crt.h
| 140| »   »   strcpy(dst,·dst_val);
|    | [MAJOR] CPPCheckBear (bufferAccessOutOfBounds):
|    | Buffer is accessed out of bounds: d5

source/lib/tests/test_secure_crt.h
| 150| »   »   strcpy(dst,·dst_val);
|    | [MAJOR] CPPCheckBear (bufferAccessOutOfBounds):
|    | Buffer is accessed out of bounds: d5

source/simulation2/components/tests/test_TerritoryManager.h
| 136| »   »   TS_ASSERT_EQUALS(onesOuter->points.size(),·20U);
|    | [MAJOR] CPPCheckBear (deadpointer):
|    | Dead pointer usage. Pointer 'onesOuter' is dead if it has been assigned '&boundary' at line 96.

source/simulation2/components/tests/test_TerritoryManager.h
| 137| »   »   TS_ASSERT_EQUALS(onesInner0->points.size(),·4U);
|    | [MAJOR] CPPCheckBear (deadpointer):
|    | Dead pointer usage. Pointer 'onesInner0' is dead if it has been assigned '&boundary' at line 105.

source/simulation2/components/tests/test_TerritoryManager.h
| 138| »   »   TS_ASSERT_EQUALS(onesInner2->points.size(),·4U);
|    | [MAJOR] CPPCheckBear (deadpointer):
|    | Dead pointer usage. Pointer 'onesInner2' is dead if it has been assigned '&boundary' at line 110.

source/simulation2/components/tests/test_TerritoryManager.h
| 139| »   »   TS_ASSERT_EQUALS(twosOuter->points.size(),·4U);
|    | [MAJOR] CPPCheckBear (deadpointer):
|    | Dead pointer usage. Pointer 'twosOuter' is dead if it has been assigned '&boundary' at line 116.

source/simulation2/components/tests/test_TerritoryManager.h
| 140| »   »   TS_ASSERT_EQUALS(threesOuter->points.size(),·4U);
|    | [MAJOR] CPPCheckBear (deadpointer):
|    | Dead pointer usage. Pointer 'threesOuter' is dead if it has been assigned '&boundary' at line 121.

source/simulation2/components/tests/test_TerritoryManager.h
| 151| »   »   TestBoundaryPointsEqual(onesOuter->points,·onesOuterExpectedPoints);
|    | [MAJOR] CPPCheckBear (deadpointer):
|    | Dead pointer usage. Pointer 'onesOuter' is dead if it has been assigned '&boundary' at line 96.

source/simulation2/components/tests/test_TerritoryManager.h
| 152| »   »   TestBoundaryPointsEqual(onesInner0->points,·onesInner0ExpectedPoints);
|    | [MAJOR] CPPCheckBear (deadpointer):
|    | Dead pointer usage. Pointer 'onesInner0' is dead if it has been assigned '&boundary' at line 105.

source/simulation2/components/tests/test_TerritoryManager.h
| 153| »   »   TestBoundaryPointsEqual(onesInner2->points,·onesInner2ExpectedPoints);
|    | [MAJOR] CPPCheckBear (deadpointer):
|    | Dead pointer usage. Pointer 'onesInner2' is dead if it has been assigned '&boundary' at line 110.

source/simulation2/components/tests/test_TerritoryManager.h
| 154| »   »   TestBoundaryPointsEqual(twosOuter->points,·twosOuterExpectedPoints);
|    | [MAJOR] CPPCheckBear (deadpointer):
|    | Dead pointer usage. Pointer 'twosOuter' is dead if it has been assigned '&boundary' at line 116.

source/simulation2/components/tests/test_TerritoryManager.h
| 155| »   »   TestBoundaryPointsEqual(threesOuter->points,·threesOuterExpectedPoints);
|    | [MAJOR] CPPCheckBear (deadpointer):
|    | Dead pointer usage. Pointer 'threesOuter' is dead if it has been assigned '&boundary' at line 121.

source/simulation2/components/tests/test_TerritoryManager.h
| 217| »   »   TS_ASSERT_EQUALS(onesOuter->points.size(),·8U);
|    | [MAJOR] CPPCheckBear (deadpointer):
|    | Dead pointer usage. Pointer 'onesOuter' is dead if it has been assigned '&boundary' at line 187.

source/simulation2/components/tests/test_TerritoryManager.h
| 218| »   »   TS_ASSERT_EQUALS(twosOuter->points.size(),·22U);
|    | [MAJOR] CPPCheckBear (deadpointer):
|    | Dead pointer usage. Pointer 'twosOuter' is dead if it has been assigned '&boundary' at line 198.

source/simulation2/components/tests/test_TerritoryManager.h
| 219| »   »   TS_ASSERT_EQUALS(twosInner->points.size(),·14U);
|    | [MAJOR] CPPCheckBear (deadpointer):
|    | Dead pointer usage. Pointer 'twosInner' is dead if it has been assigned '&boundary' at line 200.

source/simulation2/components/tests/test_TerritoryManager.h
| 220| »   »   TS_ASSERT_EQUALS(threesOuter->points.size(),·14U);
|    | [MAJOR] CPPCheckBear (deadpointer):
|    | Dead pointer usage. Pointer 'threesOuter' is dead if it has been assigned '&boundary' at line 192.

source/simulation2/components/tests/test_TerritoryManager.h
| 226| »   »   if·(twosOuter->points.size()·<·twosInner->points.size())
|    | [MAJOR] CPPCheckBear (deadpointer):
|    | Dead pointer usage. Pointer 'twosOuter' is dead if it has been assigned '&boundary' at line 198.

source/simulation2/components/tests/test_TerritoryManager.h
| 226| »   »   if·(twosOuter->points.size()·<·twosInner->points.size())
|    | [MAJOR] CPPCheckBear (deadpointer):
|    | Dead pointer usage. Pointer 'twosInner' is dead if it has been assigned '&boundary' at line 200.

source/simulation2/components/tests/test_TerritoryManager.h
| 243| »   »   TestBoundaryPointsEqual(onesOuter->points,·onesOuterExpectedPoints);
|    | [MAJOR] CPPCheckBear (deadpointer):
|    | Dead pointer usage. Pointer 'onesOuter' is dead if it has been assigned '&boundary' at line 187.

source/simulation2/components/tests/test_TerritoryManager.h
| 246| »   »   TestBoundaryPointsEqual(threesOuter->points,·threesOuterExpectedPoints);
|    | [MAJOR] CPPCheckBear (deadpointer):
|    | Dead pointer usage. Pointer 'threesOuter' is dead if it has been assigned '&boundary' at line 192.

source/tools/atlas/GameInterface/Handlers/TerrainHandlers.cpp
|  33| #include·"simulation2/components/ICmpPathfinder.h"
|    | [MAJOR] CPPCheckBear (syntaxError):
|    | Invalid number of character ({) when these macros are defined: ''.

source/tools/atlas/GameInterface/Handlers/TerrainHandlers.cpp
|  33| #include·"simulation2/components/ICmpPathfinder.h"
|    | [MAJOR] CPPCheckBear (syntaxError):
|    | Invalid number of character ({) when these macros are defined: 'MESSAGES_SKIP_STRUCTS'.

source/tools/atlas/GameInterface/Handlers/TerrainHandlers.cpp
|  33| #include·"simulation2/components/ICmpPathfinder.h"
|    | [MAJOR] CPPCheckBear (syntaxError):
|    | Invalid number of character ({) when these macros are defined: '_MSC_VER'.

source/ps/scripting/JSInterface_Debug.cpp
|  43| »   return·*(volatile·int*)0;
|    | [MAJOR] CPPCheckBear (nullPointer):
|    | Null pointer dereference

source/tools/atlas/GameInterface/Handlers/MiscHandlers.cpp
|  33| #include·"ps/Util.h"
|    | [MAJOR] CPPCheckBear (syntaxError):
|    | Invalid number of character ({) when these macros are defined: ''.

source/tools/atlas/GameInterface/Handlers/MiscHandlers.cpp
|  33| #include·"ps/Util.h"
|    | [MAJOR] CPPCheckBear (syntaxError):
|    | Invalid number of character ({) when these macros are defined: 'MESSAGES_SKIP_STRUCTS'.

source/tools/atlas/GameInterface/Handlers/MiscHandlers.cpp
|  33| #include·"ps/Util.h"
|    | [MAJOR] CPPCheckBear (syntaxError):
|    | Invalid number of character ({) when these macros are defined: '_MSC_VER'.

source/tools/atlas/GameInterface/Handlers/CommandHandlers.cpp
|  33| »   »   c·=·(it->second)(msg->data);
|    | [MAJOR] CPPCheckBear (syntaxError):
|    | Invalid number of character ({) when these macros are defined: ''.

source/tools/atlas/GameInterface/Handlers/CommandHandlers.cpp
|  33| »   »   c·=·(it->second)(msg->data);
|    | [MAJOR] CPPCheckBear (syntaxError):
|    | Invalid number of character ({) when these macros are defined: 'MESSAGES_SKIP_STRUCTS'.

source/tools/atlas/GameInterface/Handlers/CommandHandlers.cpp
|  33| »   »   c·=·(it->second)(msg->data);
|    | [MAJOR] CPPCheckBear (syntaxError):
|    | Invalid number of character ({) when these macros are defined: '_MSC_VER'.

source/tools/atlas/GameInterface/View.cpp
|  33| #include·"lib/utf8.h"
|    | [MAJOR] CPPCheckBear (syntaxError):
|    | Invalid number of character ({) when these macros are defined: ''.

source/tools/atlas/GameInterface/View.cpp
|  33| #include·"lib/utf8.h"
|    | [MAJOR] CPPCheckBear (syntaxError):
|    | Invalid number of character ({) when these macros are defined: 'CONFIG2_GLES'.

source/tools/atlas/GameInterface/View.cpp
|  33| #include·"lib/utf8.h"
|    | [MAJOR] CPPCheckBear (syntaxError):
|    | Invalid number of character ({) when these macros are defined: 'MESSAGES_SKIP_STRUCTS'.

source/tools/atlas/GameInterface/View.cpp
|  33| #include·"lib/utf8.h"
|    | [MAJOR] CPPCheckBear (syntaxError):
|    | Invalid number of character ({) when these macros are defined: '_MSC_VER'.

source/tools/atlas/GameInterface/GameLoop.cpp
|  33| #include·"lib/app_hooks.h"
|    | [MAJOR] CPPCheckBear (syntaxError):
|    | Invalid number of character ({) when these macros are defined: ''.

source/tools/atlas/GameInterface/GameLoop.cpp
|  33| #include·"lib/app_hooks.h"
|    | [MAJOR] CPPCheckBear (syntaxError):
|    | Invalid number of character ({) when these macros are defined: 'MESSAGES_SKIP_STRUCTS'.

source/tools/atlas/GameInterface/GameLoop.cpp
|  33| #include·"lib/app_hooks.h"
|    | [MAJOR] CPPCheckBear (syntaxError):
|    | Invalid number of character ({) when these macros are defined: '_MSC_VER'.

source/tools/atlas/GameInterface/Handlers/GraphicsSetupHandlers.cpp
|  33| #include·"ps/Game.h"
|    | [MAJOR] CPPCheckBear (syntaxError):
|    | Invalid number of character ({) when these macros are defined: ''.

source/tools/atlas/GameInterface/Handlers/GraphicsSetupHandlers.cpp
|  33| #include·"ps/Game.h"
|    | [MAJOR] CPPCheckBear (syntaxError):
|    | Invalid number of character ({) when these macros are defined: 'MESSAGES_SKIP_STRUCTS'.

source/tools/atlas/GameInterface/Handlers/GraphicsSetupHandlers.cpp
|  33| #include·"ps/Game.h"
|    | [MAJOR] CPPCheckBear (syntaxError):
|    | Invalid number of character ({) when these macros are defined: 'OS_MACOSX'.

source/tools/atlas/GameInterface/Handlers/GraphicsSetupHandlers.cpp
|  33| #include·"ps/Game.h"
|    | [MAJOR] CPPCheckBear (syntaxError):
|    | Invalid number of character ({) when these macros are defined: 'OS_WIN'.

source/tools/atlas/GameInterface/Handlers/GraphicsSetupHandlers.cpp
|  33| #include·"ps/Game.h"
|    | [MAJOR] CPPCheckBear (syntaxError):
|    | Invalid number of character ({) when these macros are defined: '_MSC_VER'.

source/tools/atlas/GameInterface/View.h
|  33| 
|    | [MAJOR] CPPCheckBear (syntaxError):
|    | Invalid number of character ({) when these macros are defined: ''.

source/tools/atlas/GameInterface/View.h
|  33| 
|    | [MAJOR] CPPCheckBear (syntaxError):
|    | Invalid number of character ({) when these macros are defined: 'MESSAGES_SKIP_STRUCTS'.

source/tools/atlas/GameInterface/View.h
|  33| 
|    | [MAJOR] CPPCheckBear (syntaxError):
|    | Invalid number of character ({) when these macros are defined: '_MSC_VER'.
Executing section JS...

Link to build: https://jenkins.wildfiregames.com/job/differential/780/

smiley added a subscriber: smiley.Nov 11 2018, 8:24 AM

(Same thing for static_cast as well. Maybe a ticket to correct CC should be opened.)