as the title say
Details
Details
- Reviewers
Gallaecio - Commits
- rP19255: Fix ambiguous tooltip in the trade window help
check that your understand better what the tooltip try to say :-)
Diff Detail
Diff Detail
- Repository
- rP 0 A.D. Public Repository
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Event Timeline
Comment Actions
Build is green
Updating workspaces. Build (release)... Build (debug)... Running release tests... Running cxxtest tests (302 tests)..............................................................................................................................................................................................................................................................................................................OK! Running debug tests... Running cxxtest tests (302 tests)..............................................................................................................................................................................................................................................................................................................OK!
http://jw:8080/job/phabricator/417/ for more details.
Comment Actions
Assuming that there is a single type of goods of origin and a single target type of goods, and assuming also that only the type of goods of origin (but not the target type of goods) can be set to 100% by pressing the hotkey while selecting that resource, I agree with the change.
However, I suggest “Press %(hotkey)s while selecting the type of goods of origin to set the type of goods of origin to 100%%.”. Feel free to take only parts of my suggestion or none at all, though; if my assumptions are correct, your current changes already fix the issue.
Comment Actions
yes, even the terms "origin" and "target" are not really good. In fact here there is one origin (the selected one) and all others are potential targets of the change of fraction. Maybe we should remove them as in:
Select one type of good you want to modify by clicking on it (Pressing %(hotkey)s while selecting will also bring its share to 100%), and then use the arrows of the other types of good to modify their shares.