Details
- Reviewers
bb - Commits
- rP22181: Reduce duplication in template_structure_military*
Check if nothing is overlooked and everything still works.
Diff Detail
- Repository
- rP 0 A.D. Public Repository
- Branch
- /ps/trunk
- Lint
Lint OK - Unit
No Unit Test Coverage - Build Status
Buildable 7110 Build 11607: Vulcan Build Jenkins Build 11606: arc lint + arc unit
Event Timeline
Successful build - Chance fights ever on the side of the prudent.
Link to build: https://jenkins.wildfiregames.com/job/differential/1110/display/redirect
Successful build - Chance fights ever on the side of the prudent.
Link to build: https://jenkins.wildfiregames.com/job/differential/1173/display/redirect
Changes to trivial to not accept,
checked nothing else than the buildrestriction tag changed in the final templates
Proofreading gives that nothing else can easily be moved upstairs (k, that death sound is still in the patch context, but that is already fixed globally in svn)
Took way to long to get this patch in, now I see it actually was a pretty easy one...
| binaries/data/mods/public/simulation/templates/template_structure_military.xml | ||
|---|---|---|
| 14 | That is a template change, but a good one, grepped for completeness. | |
| binaries/data/mods/public/simulation/templates/template_structure_military_blacksmith.xml | ||
| 71 | != 40000 | |
| binaries/data/mods/public/simulation/templates/template_structure_military_embassy.xml | ||
| 61–65 | 2 nukable lines | |
| binaries/data/mods/public/simulation/templates/template_structure_military_fortress.xml | ||
| 58 | != 0.1 | |