variable SearchString is not used
Details
Details
Diff Detail
Diff Detail
- Repository
- rP 0 A.D. Public Repository
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Event Timeline
Comment Actions
Successful build - Chance fights ever on the side of the prudent.
Linter detected issues: Executing section Source... source/gui/CInput.cpp | 1| /*·Copyright·(C)·2017·Wildfire·Games. | | [NORMAL] LicenseYearBear: | | License should have "2019" year instead of "2017" Executing section JS... Executing section cli...
Link to build: https://jenkins.wildfiregames.com/job/differential/1163/display/redirect
Comment Actions
That must be a copy-pasta, text.delete.right doesn't have it, so completeness in that sense
compiles, front doesn't fall => accept
Comment Actions
15:34 < bb> just leaving it accepted for a short while (till tonight) in case someone wants to add something
- One may check for other unused vars in the same file (the compiler should already be checking for that)
- One may want to find the revision (for referencing, possible audit, revision of the underlying feature design, discovery of forgotton implementation ideas etc)
may = may chose not to
Comment Actions
I have been checking whole project for unused variables and have split revisions based on files. So no another unused variable in this file.
forgot Implementation might be to not have *pCaption but searchString directly.
Revision: rP9646