Page MenuHomeWildfire Games

Use arrow functions in ai filters
Needs ReviewPublic

Authored by bb on May 13 2019, 7:46 PM.

Details

Reviewers
wraitii
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Summary

Cleaning the filters.js file from the ai

Test Plan

Let the bots run

Diff Detail

Repository
rP 0 A.D. Public Repository
Branch
/ps/trunk
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 7669
Build 12502: Vulcan BuildJenkins
Build 12501: arc lint + arc unit

Event Timeline

bb created this revision.May 13 2019, 7:46 PM
Owners added a subscriber: Restricted Owners Package.May 13 2019, 7:46 PM

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/differential/1392/display/redirect

elexis added a subscriber: elexis.May 19 2019, 2:46 PM

return can be avoided using parentheses.
Considered checking up/down/other stream?

wraitii added a reviewer: Restricted Owners Package.May 25 2019, 2:42 PM
wraitii requested changes to this revision.May 28 2019, 5:25 PM
wraitii added a subscriber: wraitii.

Skip the returns as elexis said

This revision now requires changes to proceed.May 28 2019, 5:25 PM
bb updated this revision to Diff 8207.May 29 2019, 10:04 PM

Brackets

Up/Down: made this because I stumbled upon this when working on some other patches
Other: kindof hard to look into something without access

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/differential/1543/display/redirect