Differential D1917

?) - Replace pthread in other engine files
ClosedPublic
Actions

Authored by wraitii on May 25 2019, 7:18 PM.

Details

Reviewers

None

Group Reviewers

Windows Developers
Restricted Owners Package	(Owns No Changed Paths)

Commits

rP22649: pthread -> std::thread (3/7) - Replace pthread in other engine files

Summary

Some engine files use worker threads, so use std::thread there.

Still remaining is the net and mongoose stuff.

Test Plan

Compile, check that things still work.

Diff Detail

Repository

rP 0 A.D. Public Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

wraitii created this revision.May 25 2019, 7:18 PM

Owners added subscribers: Restricted Owners Package, Restricted Owners Package.May 25 2019, 7:18 PM

Build failure - The Moirai have given mortals hearts that can endure.

Link to build: https://jenkins.wildfiregames.com/job/differential/1491/display/redirect

Harbormaster failed remote builds in B7596: Diff 8134!May 25 2019, 7:18 PM

wraitii added a child revision: D1920: pthread -> std::thread (4/?) - Replace pthread in remaining files.May 26 2019, 7:30 PM

wraitii added a parent revision: D1916: pthread -> std::thread (2/7) - Remove dependencies in Profilers.

wraitii mentioned this in rP22344: Clean up ThreadUtil, use standard C++11 constructs instead of custom ones..Jun 7 2019, 4:11 PM

Rebased, tested

Successful build - Chance fights ever on the side of the prudent.

Linter detected issues:
Executing section Source...

source/graphics/TextureConverter.cpp
|   1| /*·Copyright·(C)·2015·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2019" year instead of "2015"

source/graphics/MapGenerator.h
|  41| class·CMapGenerator
|    | [MAJOR] CPPCheckBear (syntaxError):
|    | Code 'classCMapGenerator{' is invalid C code. Use --std or --language to configure the language.

source/graphics/TextureConverter.h
|   1| /*·Copyright·(C)·2012·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2019" year instead of "2012"

source/graphics/TextureConverter.h
|  71| »   »   FMT_DXT3,
|    | [MAJOR] CPPCheckBear (syntaxError):
|    | Code 'classCTextureManager{' is invalid C code. Use --std or --language to configure the language.

source/lib/timer.cpp
|   1| /*·Copyright·(C)·2010·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2019" year instead of "2010"

source/tools/atlas/GameInterface/GameLoop.cpp
|   1| /*·Copyright·(C)·2017·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2019" year instead of "2017"

source/tools/atlas/GameInterface/GameLoop.cpp
| 211| »   »   //////////////////////////////////////////////////////////////////////////
|    | [MAJOR] CPPCheckBear (syntaxError):
|    | Unmatched '}'. Configuration: 'MESSAGESSETUP_NOTFIRST'.
Executing section JS...
Executing section cli...

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/301/display/redirect

Harbormaster completed remote builds in B8727: Diff 9217.Aug 4 2019, 11:47 AM

This revision was not accepted when it landed; it landed in state Needs Review.Aug 12 2019, 10:16 AM

Closed by commit rP22649: pthread -> std::thread (3/7) - Replace pthread in other engine files (authored by wraitii). · Explain Why

This revision was automatically updated to reflect the committed changes.

wraitii added a commit: rP22649: pthread -> std::thread (3/7) - Replace pthread in other engine files.