Page MenuHomeWildfire Games

pthread -> std::thread (4/?) - Replace pthread in remaining files
ClosedPublic

Authored by wraitii on May 26 2019, 6:07 PM.

Details

Reviewers
None
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Commits
rP22666: pthread -> std::thread (4/7) - Replace pthread in remaining files
Summary

This removes pthread mutexes/threads from other core 0A.D. files. Remain the mongoose file and the x86_64 weird computation, as well as the message passing with atlas.

Test Plan

Compile, test.

Diff Detail

Repository
rP 0 A.D. Public Repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

wraitii created this revision.May 26 2019, 6:07 PM

Build failure - The Moirai have given mortals hearts that can endure.

Link to build: https://jenkins.wildfiregames.com/job/differential/1513/display/redirect

Stan added a subscriber: Stan.May 26 2019, 7:08 PM
Stan added inline comments.
source/network/NetServer.cpp
264 ↗(On Diff #8163)

Why remove the early returns ?

350 ↗(On Diff #8163)

could be renamed to worker ?

wraitii added inline comments.May 26 2019, 7:18 PM
source/network/NetServer.cpp
264 ↗(On Diff #8163)

er, should have made this into return;, I went too quickly.

Stan added inline comments.May 26 2019, 7:20 PM
source/network/NetServer.cpp
350 ↗(On Diff #8163)

Any reason by the way why it can't be a general worker ?

wraitii updated this revision to Diff 9313.Mon, Aug 12, 3:35 PM

Bring back the early returns;

Successful build - Chance fights ever on the side of the prudent.

Linter detected issues:
Executing section Source...

source/network/NetServer.h
|  46| »   //·The·worker·thread·has·not·been·started.
|    | [MAJOR] CPPCheckBear (syntaxError):
|    | Code 'classCNetFileReceiveTask{' is invalid C code. Use --std or --language to configure the language.

source/lib/posix/posix.h
|   1| /*·Copyright·(C)·2010·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2019" year instead of "2010"

source/lib/file/vfs/vfs.cpp
|   1| /*·Copyright·(C)·2017·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2019" year instead of "2017"

source/lib/file/vfs/vfs.h
|   1| /*·Copyright·(C)·2017·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2019" year instead of "2017"

source/lib/file/vfs/vfs.h
|  34| namespace·ERR
|    | [MAJOR] CPPCheckBear (syntaxError):
|    | Code 'namespaceERR{' is invalid C code. Use --std or --language to configure the language.

source/lib/res/h_mgr.cpp
|   1| /*·Copyright·(C)·2013·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2019" year instead of "2013"
Executing section JS...
Executing section cli...

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/369/display/redirect

Stan added inline comments.Mon, Aug 12, 4:08 PM
source/lib/file/vfs/vfs.cpp
45 ↗(On Diff #9313)

Missing an include ?

wraitii updated this revision to Diff 9330.Thu, Aug 15, 9:45 AM

Add include, RC

Successful build - Chance fights ever on the side of the prudent.

Linter detected issues:
Executing section Source...

source/network/NetServer.h
|  46| »   //·The·worker·thread·has·not·been·started.
|    | [MAJOR] CPPCheckBear (syntaxError):
|    | Code 'classCNetFileReceiveTask{' is invalid C code. Use --std or --language to configure the language.

source/lib/file/vfs/vfs.cpp
|   1| /*·Copyright·(C)·2017·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2019" year instead of "2017"

source/lib/file/vfs/vfs.h
|   1| /*·Copyright·(C)·2017·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2019" year instead of "2017"

source/lib/file/vfs/vfs.h
|  34| namespace·ERR
|    | [MAJOR] CPPCheckBear (syntaxError):
|    | Code 'namespaceERR{' is invalid C code. Use --std or --language to configure the language.

source/lib/posix/posix.h
|   1| /*·Copyright·(C)·2010·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2019" year instead of "2010"

source/lib/res/h_mgr.cpp
|   1| /*·Copyright·(C)·2013·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2019" year instead of "2013"
Executing section JS...
Executing section cli...

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/378/display/redirect

This revision was not accepted when it landed; it landed in state Needs Review.Thu, Aug 15, 11:07 AM
This revision was automatically updated to reflect the committed changes.