Page MenuHomeWildfire Games

Fix no-pch build following renderer options refactoring rP22610
ClosedPublic

Authored by wraitii on Sun, Aug 4, 9:30 PM.

Details

Summary

LOGWARNING requires CLogger following

See refactoring of renderer options in rP22610.

Test Plan

Compile without precompiled headers.

Diff Detail

Repository
rP 0 A.D. Public Repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

wraitii created this revision.Sun, Aug 4, 9:30 PM
Owners added a subscriber: Restricted Owners Package.Sun, Aug 4, 9:30 PM
Vulcan added a comment.Sun, Aug 4, 9:32 PM

Build failure - The Moirai have given mortals hearts that can endure.

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/308/display/redirect

elexis accepted this revision.Sun, Aug 4, 9:37 PM
elexis added a subscriber: elexis.

The inclusion is correct, just not in alphabetic order.

Seems like this file is in reverse alphebtic order, so the insertion is consistent :P

(One can be lazy and copy&paste headers to https://alphabetizer.flap.tv/)

Also newline for `RenderingOptions.h, so that it stands out as the header of the current file, see https://trac.wildfiregames.com/wiki/Coding_Conventions#Preprocessorinstructions

This revision is now accepted and ready to land.Sun, Aug 4, 9:37 PM
elexis retitled this revision from Fix no-pch build following rP22610 to Fix no-pch build following renderer options refactoring rP22610.Sun, Aug 4, 9:40 PM
elexis edited the summary of this revision. (Show Details)

Our sorting is case-insensitive so the file was actually ordered correctly before. Will fix when committing.

This revision was landed with ongoing or failed builds.Sun, Aug 4, 10:08 PM
This revision was automatically updated to reflect the committed changes.