Had it like that originally, shouldn't have doubted...
Details
Details
Diff Detail
Diff Detail
- Repository
- rP 0 A.D. Public Repository
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Event Timeline
Comment Actions
Successful build - Chance fights ever on the side of the prudent.
Link to build: https://jenkins.wildfiregames.com/job/docker-differential/391/display/redirect
Comment Actions
Ideally there would be no type conversions and all values are constructed in the right type, and the functions receiving them expect exactly that type.
I didnt check much of the code, but GetVertexGroundLevel expects the signed variant already, so it might be right with signed.
Should check that there arent unintented implicit type conversions.
Compile warning is gone.