Remove CCheckbox text remains
ClosedPublic
Actions

Authored by elexis on Sep 21 2019, 5:02 AM.

Details

Reviewers: None
Commits: rP22952: Delete unused CCheckbox text setting remains following rP14476, refs rP18419.

Summary

rP14476 removed somehow broken text rendering of the checkbox, but left big parts of the text code in that class.
rP18419 added a TODO for that.

Test Plan

Check that all styles and GUI object definitions for checkboxes have the removed text settings also removed, otherwise you'll get LOGERROR and LOGWARNING.
Load every page once to verify:

gamesetup/gamesetup.xml:				<object name="displaySPTips" size="8 100%-30 28 100%-8" type="checkbox" style="ModernTickBox">
gamesetup/gamesetup.xml:							type="checkbox"
gamesetup_mp/gamesetup_mp.xml:				<object name="useSTUN" size="0 10 32 100%" type="checkbox" style="ModernTickBox">
loadgame/load.xml:			<object name="compatibilityFilter" type="checkbox" checked="true" style="ModernTickBox" size="0 0 20 20">
lobby/lobby_panels.xml:			<object name="filterOpenGames" type="checkbox" checked="false" style="ModernTickBox" size="0 0 20 20">
options/options.xml:					<object name="option_control_boolean[n]" size="90% 2 100% 100%+2" type="checkbox" style="ModernTickBox"/>
prelobby/common/credentials/rememberpassword.xml:	<object name="rememberPassword" type="checkbox" size="40%-19 0 40% 20" style="ModernTickBox">
replaymenu/replay_menu.xml:			<object name="compatibilityFilter" type="checkbox" checked="true" style="ModernTickBox" size="0 4 20 100%">
replaymenu/replay_menu.xml:				<object name="showSpoiler" type="checkbox" checked="false" style="ModernTickBox" size="10 100%-27 30 100%">
session/chat_window.xml:			type="checkbox"
session/developer_overlay.xml:				<object name="dev_command_checkbox[n]" size="100%-24 1 100% 100%" type="checkbox" style="ModernTickBox"/>
session/top_panel.xml:			type="checkbox"
splashscreen/splashscreen.xml:			<object name="displaySplashScreen" size="8 100%-30 22 100%-8" type="checkbox" style="ModernTickBox"/>


gui/modmod/modmod.xml:				type="checkbox"

Diff Detail

Repository

rP 0 A.D. Public Repository

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

elexis created this revision.Sep 21 2019, 5:02 AM

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/vs2015-differential/271/display/redirect

Successful build - Chance fights ever on the side of the prudent.

Linter detected issues:
Executing section Source...

source/gui/CCheckBox.h
|  23| class·CCheckBox·:·public·IGUIButtonBehavior
|    | [MAJOR] CPPCheckBear (syntaxError):
|    | Code 'classCCheckBox:' is invalid C code. Use --std or --language to configure the language.
Executing section JS...
Executing section cli...

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/783/display/redirect

Harbormaster completed remote builds in B9518: Diff 9891.Sep 21 2019, 5:09 AM

This revision was not accepted when it landed; it landed in state Needs Review.Sep 21 2019, 5:11 AM

Closed by commit rP22952: Delete unused CCheckbox text setting remains following rP14476, refs rP18419. (authored by elexis). · Explain Why

This revision was automatically updated to reflect the committed changes.

elexis added a commit: rP22952: Delete unused CCheckbox text setting remains following rP14476, refs rP18419..

Owners added a subscriber: Restricted Owners Package.Sep 21 2019, 5:11 AM

elexis mentioned this in D2318: Defragment IGUIButtonBehavior members.Sep 22 2019, 4:01 PM

elexis mentioned this in rP22969: Defragment IGUIButtonBehavior Settings..Sep 22 2019, 4:53 PM

elexis mentioned this in rP22975: Warn if the derived class and the base class have the same AddSetting call….Sep 23 2019, 12:49 AM