HomeWildfire Games

Delete unused CCheckbox text setting remains following rP14476, refs rP18419.

Description

Delete unused CCheckbox text setting remains following rP14476, refs rP18419.

Differential Revision: https://code.wildfiregames.com/D2314
Tested on: clang 8.0.1., Jenkins

Details

Event Timeline

elexis added inline comments.
/ps/trunk/source/gui/CCheckBox.cpp
55

Following rP14476 IGUIButtonBehavior::ChooseColor() is only called from CButton, so should be moved over there as well in rP14476 or rP22952.

const CGUIColor& 
{
	// Yes, the object must possess these settings. They are standard
	const CGUIColor& color = GetSetting<CGUIColor>("textcolor");

If the comment originating at rP290 had been true before then, the IGUIButtonBehavior constructor should have called AddSetting, not the constructor of derived classes.