If removing the DrawText call is right, then this should not only remove the DrawText call but also CCheckBox::SetupText(), the according Settings, and IGUITextOwner inheritance.

non-obvious internal text rendering

sounds like the text either might still rendered in a non obvious place, or that the previous code was non obvious.

As far as I see DrawText is the only place where text is rendered, and that is only called from IGUIObject classes (the leaf classes).

Marked as TODO in rP18419.

This commit now has outstanding concerns.Aug 23 2019, 4:29 PM

elexis mentioned this in rP22765: Replace copy-assigning GUI<T>::GetSetting from rP31 with the reference….Aug 23 2019, 4:43 PM

elexis mentioned this in D2314: Remove CCheckbox text remains.Sep 21 2019, 5:02 AM

elexis mentioned this in rP22952: Delete unused CCheckbox text setting remains following rP14476, refs rP18419..Sep 21 2019, 5:11 AM

Rest of the text code removed in rP22952.
Not sure if it wouldnt be better if the class supports rendering text (most other GUIs do?), also the implementation didnt duplicate the text rendering like other classes do (CInput).
But given that now the entire GUI uses its own labels, one would have to rewrite most checkboxes to make use of that feature if it was implemented, so good enough for me until someone wants to implement it back.

All concerns with this commit have now been addressed.Sep 21 2019, 5:49 AM

elexis mentioned this in D2318: Defragment IGUIButtonBehavior members.Sep 22 2019, 3:37 PM

elexis mentioned this in rP22969: Defragment IGUIButtonBehavior Settings..Sep 22 2019, 4:53 PM