Diffusion 0 A.D. Public Repository rP22975

Warn if the derived class and the base class have the same AddSetting call…
rP22975
Actions

Tags

None

Subscribers

None

Description

Warn if the derived class and the base class have the same AddSetting call instead of silently ignoring it.

Enabled by rP22958 (refs rP22952 / D2314, rP22969 / D2318).
Helps structuring the GUI so that AddSetting and GetSetting are in the same file, which defragments code and may allow for future optimizations (setting values as class members for Draw calls), refs D2313.

Differential Revision: https://code.wildfiregames.com/D2320
Tested on: clang 8.0.1, Jenkins

Details

Committed

Sep 23 2019, 12:49 AM

Differential Revision

D2320: Warn if GUI object base and derived class call AddSetting for the same property

Parents

rP22974: [Windows] Automated build.

Branches

Unknown

Tags

Unknown

Build Status

Buildable 9562
Build 15992: Trigger Windows Autobuild
Build 15991: Post-Commit Build	Jenkins

Event Timeline

elexis committed rP22975: Warn if the derived class and the base class have the same AddSetting call….Sep 23 2019, 12:49 AM

elexis added an edge: D2320: Warn if GUI object base and derived class call AddSetting for the same property.

Harbormaster completed building B9562: rP22975: Warn if the derived class and the base class have the same AddSetting call….Sep 23 2019, 12:54 AM

Changes (2)

Path

Size

ps/

trunk/

source/

gui/

rP22975

ps/trunk/source/gui/CDropDown.cpp

Loading...

ps/trunk/source/gui/IGUIObject.cpp

Loading...